Re: [patch 3/6] Add 8548 CDS PCI express controller node and PCI-X device node

2007-07-16 Thread Zang Roy-r61911
On Mon, 2007-07-16 at 23:00, Segher Boessenkool wrote: > is this the only fix, I've already applied a version of this to > my > tree (with the irq sense fix) and just want to make sure there > isn't > anything else. > >>> I do not get more. > >>> I'd like to enroll Segher's su

Re: [patch 3/6] Add 8548 CDS PCI express controller node and PCI-X device node

2007-07-16 Thread Segher Boessenkool
is this the only fix, I've already applied a version of this to my tree (with the irq sense fix) and just want to make sure there isn't anything else. >>> I do not get more. >>> I'd like to enroll Segher's suggestion together with VIA chip >>> function >>> in next step. >>>

Re: [patch 3/6] Add 8548 CDS PCI express controller node and PCI-X device node

2007-07-16 Thread Kumar Gala
On Jul 16, 2007, at 8:05 AM, Segher Boessenkool wrote: >>> is this the only fix, I've already applied a version of this to my >>> tree (with the irq sense fix) and just want to make sure there isn't >>> anything else. >> I do not get more. >> I'd like to enroll Segher's suggestion together with V

Re: [patch 3/6] Add 8548 CDS PCI express controller node and PCI-X device node

2007-07-16 Thread Segher Boessenkool
>> is this the only fix, I've already applied a version of this to my >> tree (with the irq sense fix) and just want to make sure there isn't >> anything else. > I do not get more. > I'd like to enroll Segher's suggestion together with VIA chip function > in next step. > We need to make basic pcie

Re: [patch 3/6] Add 8548 CDS PCI express controller node and PCI-X device node

2007-07-12 Thread Zang Roy-r61911
On Thu, 2007-07-12 at 17:00, Kumar Gala wrote: > On Jul 12, 2007, at 3:27 AM, Zang Roy-r61911 wrote: > > > From: Roy Zang <[EMAIL PROTECTED]> > > > > Add 8548 CDS PCI express controller node and PCI-X device node. > > The current dts file is suitable for 8548 Rev 2.0 board with > > Arcadia 3.1. >

Re: [patch 3/6] Add 8548 CDS PCI express controller node and PCI-X device node

2007-07-12 Thread Kumar Gala
On Jul 12, 2007, at 3:27 AM, Zang Roy-r61911 wrote: > From: Roy Zang <[EMAIL PROTECTED]> > > Add 8548 CDS PCI express controller node and PCI-X device node. > The current dts file is suitable for 8548 Rev 2.0 board with > Arcadia 3.1. > This kind of board combination is the most popular. > > Ind

Re: [patch 3/6] Add 8548 CDS PCI express controller node and PCI-X device node

2007-07-12 Thread Zang Roy-r61911
From: Roy Zang <[EMAIL PROTECTED]> Add 8548 CDS PCI express controller node and PCI-X device node. The current dts file is suitable for 8548 Rev 2.0 board with Arcadia 3.1. This kind of board combination is the most popular. Indentify pci, pcie host by compatible property "fsl,mpc85xx-pci" and "

Re: [patch 3/6] Add 8548 CDS PCI express controller node and PCI-X device node

2007-07-12 Thread Kumar Gala
> + [EMAIL PROTECTED] { + interrupt-map-mask = ; + interrupt-map = < + + /* IDSEL 0x0 (PEX) */ + 0 0 0 1 &mpic 0 1 + 0 0

Re: [patch 3/6] Add 8548 CDS PCI express controller node and PCI-X device node

2007-07-11 Thread Segher Boessenkool
>>> pci1: [EMAIL PROTECTED] { >>> interrupt-map-mask = <1f800 0 0 7>; >> >> Set the mask to <1800 0 0 7>, and you need only 16 >> entries to encode the swizzle. Except... >> >>> + /* bus 1 , idsel 0x2 Tsi310 bridge >> secondary */ >>

Re: [patch 3/6] Add 8548 CDS PCI express controller node and PCI-X device node

2007-07-11 Thread Segher Boessenkool
>>> + compatible = "fsl,mpc86xx-pciex","86xx"; >> >> And "xx" again. Aren't the 85- and 86- PCIe controllers >> compatible, btw? > > They are, but we need to distinguish between 83xx, 85xx, and 86xx > pci, pciex, pci-x controllers. Sure, but if 85xx-pcie and 86xx-pcie are comp

Re: [patch 3/6] Add 8548 CDS PCI express controller node and PCI-X device node

2007-07-10 Thread Zang Roy-r61911
On Wed, 2007-07-11 at 04:25, Segher Boessenkool wrote: > > pci1: [EMAIL PROTECTED] { > > interrupt-map-mask = <1f800 0 0 7>; > > Set the mask to <1800 0 0 7>, and you need only 16 > entries to encode the swizzle. Except... > > > + /

Re: [patch 3/6] Add 8548 CDS PCI express controller node and PCI-X device node

2007-07-10 Thread Kumar Gala
On Jul 10, 2007, at 3:25 PM, Segher Boessenkool wrote: >> pci1: [EMAIL PROTECTED] { >> interrupt-map-mask = <1f800 0 0 7>; > > Set the mask to <1800 0 0 7>, and you need only 16 > entries to encode the swizzle. Except... > >> +/* bus

Re: [patch 3/6] Add 8548 CDS PCI express controller node and PCI-X device node

2007-07-10 Thread Segher Boessenkool
> pci1: [EMAIL PROTECTED] { > interrupt-map-mask = <1f800 0 0 7>; Set the mask to <1800 0 0 7>, and you need only 16 entries to encode the swizzle. Except... > + /* bus 1 , idsel 0x2 Tsi310 bridge secondary */ ...interrupts on bus

[patch 3/6] Add 8548 CDS PCI express controller node and PCI-X device node

2007-07-10 Thread Zang Roy-r61911
From: Roy Zang <[EMAIL PROTECTED]> Add 8548 CDS PCI express controller node and PCI-X device node. The current dts file is suitable for 8548 Rev 2.0 board with Arcadia 3.1. This kind of board combination is the most popular. Indentify pci, pcie host by compatible property "fsl,mpc85xx-pci" and "