> -Original Message-
> From: David Brownell [mailto:[EMAIL PROTECTED]
> Sent: den 1 maj 2008 00:56
> To: Andrew Morton
> Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; linuxppc-dev@ozlabs.org;
> [EMAIL PROTECTED]
> Subject: Re: [patch 2.6.25-git] spi_mpc83xx much im
On Wednesday 30 April 2008, Andrew Morton wrote:
> > + spin_lock_irq(&mpc83xx_spi->lock);
>
> irq-safe.
>
> > ...
> >
> > + spin_lock(&mpc83xx_spi->lock);
>
> not irq-safe.
>
> Deliberate?
That latter one is inside an #if 0/#endif block, so it won't matter.
The #if 0 block bothered me.
On Wed, 30 Apr 2008 15:37:07 -0700
David Brownell <[EMAIL PROTECTED]> wrote:
> From: Joakim Tjernlund <[EMAIL PROTECTED]>
> Date: Fri, 11 Apr 2008 18:57:21 +0200
> Subject: [PATCH] Much improved mpc83xx SPI driver.
>
> The current driver may cause glitches on SPI CLK line since one must
> disable
From: Joakim Tjernlund <[EMAIL PROTECTED]>
Date: Fri, 11 Apr 2008 18:57:21 +0200
Subject: [PATCH] Much improved mpc83xx SPI driver.
The current driver may cause glitches on SPI CLK line since one must
disable the SPI controller before changing any HW settings. Fix this
by implementing a local spi
