> -----Original Message----- > From: David Brownell [mailto:[EMAIL PROTECTED] > Sent: den 1 maj 2008 00:56 > To: Andrew Morton > Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; linuxppc-dev@ozlabs.org; > [EMAIL PROTECTED] > Subject: Re: [patch 2.6.25-git] spi_mpc83xx much improved driver > > On Wednesday 30 April 2008, Andrew Morton wrote: > > > + spin_lock_irq(&mpc83xx_spi->lock); > > > > irq-safe. > > > > > ... > > > > > > + spin_lock(&mpc83xx_spi->lock); > > > > not irq-safe. > > > > Deliberate? > > That latter one is inside an #if 0/#endif block, so it won't matter. > The #if 0 block bothered me. Maybe Joakim can remove it.
The non irq-safe spin_lock was there before my patch and now it is removed with the #if 0/#endif block. I don't need this code but I left it there disabled to make it clear for everyone else that it was removed. I can remove it but I rather leave it there for one release so everyone will have a chance to see it and object if they feel differently. > > (By the way, I'd feel safer about this patch if there were an > ack or two from more PPC folk...) Yeah, that would be good. Jocke _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
