Re: [RFC] [PATCH] Trace TLBIE's

2017-04-05 Thread Balbir Singh
On Thu, 2017-04-06 at 16:03 +1000, Michael Ellerman wrote: > Alistair Popple writes: > > > On Wed, 23 Nov 2016 10:40:36 PM Balbir Singh wrote: > > > > > > > But overall I guess it's OK. We'd want to do a quick benchmark to make > > > > sure it's not adding any overhead. > > > > > > OK.. I'll tr

Re: [RFC] [PATCH] Trace TLBIE's

2017-04-05 Thread Michael Ellerman
Alistair Popple writes: > On Wed, 23 Nov 2016 10:40:36 PM Balbir Singh wrote: >> >> > But overall I guess it's OK. We'd want to do a quick benchmark to make >> > sure it's not adding any overhead. >> >> OK.. I'll try and find a benchmark and run it with traces disabled. > > For what's it's worth

Re: [RFC] [PATCH] Trace TLBIE's

2017-04-05 Thread Alistair Popple
On Wed, 23 Nov 2016 10:40:36 PM Balbir Singh wrote: > > > But overall I guess it's OK. We'd want to do a quick benchmark to make > > sure it's not adding any overhead. > > OK.. I'll try and find a benchmark and run it with traces disabled. For what's it's worth I didn't notice any slow down runnin

Re: [RFC] [PATCH] Trace TLBIE's

2016-11-23 Thread Balbir Singh
On 23/11/16 21:15, Michael Ellerman wrote: > Balbir Singh writes: > >> Just a quick patch to trace tlbie(l)'s. The idea being that it can be >> enabled when we suspect corruption or when we need to see if we are doing >> the right thing during flush. I think the format can be enhanced to >> mak

Re: [RFC] [PATCH] Trace TLBIE's

2016-11-23 Thread Michael Ellerman
Balbir Singh writes: > Just a quick patch to trace tlbie(l)'s. The idea being that it can be > enabled when we suspect corruption or when we need to see if we are doing > the right thing during flush. I think the format can be enhanced to > make it nicer (expand the RB/RS/IS/L cases in more detai

[RFC] [PATCH] Trace TLBIE's

2016-11-23 Thread Balbir Singh
Just a quick patch to trace tlbie(l)'s. The idea being that it can be enabled when we suspect corruption or when we need to see if we are doing the right thing during flush. I think the format can be enhanced to make it nicer (expand the RB/RS/IS/L cases in more detail). For now I am sharing the i