On Wed, 23 Nov 2016 10:40:36 PM Balbir Singh wrote: > > > But overall I guess it's OK. We'd want to do a quick benchmark to make > > sure it's not adding any overhead. > > OK.. I'll try and find a benchmark and run it with traces disabled.
For what's it's worth I didn't notice any slow down running a NAMD test with tracing disabled and ~400000 tlbie's in 34s. Turning tracing on could have slowed things down ever so slightly, but I didn't notice as it may have just been in the noise of the benchmark I was running (I wasn't specifically looking at timing, hence the vagueness of the remarks). Otherwise the patch worked and would be useful - I have already had to setup tlbie counting/tracing several times in the last 12 months. Tested-by: Alistair Popple <alist...@popple.id.au> - Alistair > Thanks for the review > Balbir Singh
