Re: [RFC][PATCH] ppc: Implement save_stack_trace_regs()

2016-01-11 Thread Steven Rostedt
On Mon, 11 Jan 2016 14:30:31 +1100 Michael Ellerman wrote: > Sorry, yep I'll take it. > > I trimmed the change log a bit, final version below. > > cheers > Thanks, appreciate it! -- Steve ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org

Re: [RFC][PATCH] ppc: Implement save_stack_trace_regs()

2016-01-10 Thread Michael Ellerman
On Fri, 2016-01-08 at 17:50 -0500, Steven Rostedt wrote: > On Wed, 16 Dec 2015 12:24:19 -0500 > Steven Rostedt wrote: > > On Wed, 09 Dec 2015 12:03:05 +1100 > > Michael Ellerman wrote: > > > > > Should I take this via powerpc or do you want it to go in via tracing? > > > > > > > > You can take it

Re: [RFC][PATCH] ppc: Implement save_stack_trace_regs()

2016-01-08 Thread Steven Rostedt
On Wed, 16 Dec 2015 12:24:19 -0500 Steven Rostedt wrote: > On Wed, 09 Dec 2015 12:03:05 +1100 > Michael Ellerman wrote: > > > > > Should I take this via powerpc or do you want it to go in via tracing? > > > > > > > > > > You can take it. And you can replace the PT_R1 if you want. I just >

Re: [RFC][PATCH] ppc: Implement save_stack_trace_regs()

2015-12-16 Thread Steven Rostedt
On Wed, 09 Dec 2015 12:03:05 +1100 Michael Ellerman wrote: > > > Should I take this via powerpc or do you want it to go in via tracing? > > > > You can take it. And you can replace the PT_R1 if you want. I just > > noticed that it was defined, and I try to use macro names instead of > > hard c

Re: [RFC][PATCH] ppc: Implement save_stack_trace_regs()

2015-12-08 Thread Steven Rostedt
On Wed, 09 Dec 2015 12:03:05 +1100 Michael Ellerman wrote: > Looks like we actually have: > > #define kernel_stack_pointer(regs) ((regs)->gpr[1]) > > So that would be the most self documenting way to do it I guess, though I've > never actually seen that macro used anywhere before :) Cool, t

Re: [RFC][PATCH] ppc: Implement save_stack_trace_regs()

2015-12-08 Thread Michael Ellerman
On Tue, 2015-12-08 at 19:28 -0500, Steven Rostedt wrote: > On Wed, 09 Dec 2015 11:20:22 +1100 > Michael Ellerman wrote: > > On Tue, 2015-12-08 at 13:50 -0500, Steven Rostedt wrote: > > > It has come to my attention that kprobe event stack tracing does not > > > work on powerpc. > > > diff --git

Re: [RFC][PATCH] ppc: Implement save_stack_trace_regs()

2015-12-08 Thread Steven Rostedt
On Wed, 09 Dec 2015 11:20:22 +1100 Michael Ellerman wrote: > On Tue, 2015-12-08 at 13:50 -0500, Steven Rostedt wrote: > > > It has come to my attention that kprobe event stack tracing does not > > work on powerpc. > > Yep looks like you're right. I didn't realise it was separate from the regu

Re: [RFC][PATCH] ppc: Implement save_stack_trace_regs()

2015-12-08 Thread Michael Ellerman
On Tue, 2015-12-08 at 13:50 -0500, Steven Rostedt wrote: > It has come to my attention that kprobe event stack tracing does not > work on powerpc. Yep looks like you're right. I didn't realise it was separate from the regular stack trace stuff. > diff --git a/arch/powerpc/kernel/stacktrace.c >

[RFC][PATCH] ppc: Implement save_stack_trace_regs()

2015-12-08 Thread Steven Rostedt
It has come to my attention that kprobe event stack tracing does not work on powerpc. You can see with the following: # cd /sys/kernel/debug/tracing # echo stacktrace > trace_options # echo 'p kfree' > kprobe_events # echo 'r exit_mmap' >> kprobe_events # echo 1 > events/kprobes/enable Gives