Re: [RFC,PATCH] Cleanup PC parallel port Kconfig

2011-06-15 Thread Russell King - ARM Linux
On Wed, Jun 15, 2011 at 08:08:05AM -0700, H. Peter Anvin wrote: > On 06/15/2011 12:47 AM, Russell King - ARM Linux wrote: > >> > >> OK, serial-8250 is clearly just plain wrong, since the 8250 series UARTs > >> are ubiquitous across just about every platform. > >> > >> Floppy is special (in the shor

Re: [RFC,PATCH] Cleanup PC parallel port Kconfig

2011-06-15 Thread H. Peter Anvin
On 06/15/2011 12:39 AM, Russell King - ARM Linux wrote: > On Tue, Jun 14, 2011 at 09:31:27PM -0700, H. Peter Anvin wrote: >> On 06/14/2011 03:08 PM, Luck, Tony wrote: >>> I took a look at the back of all my ia64 systems - none of them >>> have a parallel port. It seems unlikely that new systems wi

Re: [RFC,PATCH] Cleanup PC parallel port Kconfig

2011-06-15 Thread H. Peter Anvin
On 06/15/2011 12:47 AM, Russell King - ARM Linux wrote: >> >> OK, serial-8250 is clearly just plain wrong, since the 8250 series UARTs >> are ubiquitous across just about every platform. >> >> Floppy is special (in the short bus sense), since it is closely tied to >> ISA DMA. Conditionalizing this

Re: [RFC,PATCH] Cleanup PC parallel port Kconfig

2011-06-15 Thread Guenter Roeck
On Wed, Jun 15, 2011 at 04:34:37AM -0400, Ralf Baechle wrote: > On Tue, Jun 14, 2011 at 09:18:36PM -0700, H. Peter Anvin wrote: > > > On 06/14/2011 03:34 PM, Ralf Baechle wrote: > > > > > > There is no point in offering to build something that couldn't possibly be > > > used. It just makes the k

Re: [RFC,PATCH] Cleanup PC parallel port Kconfig

2011-06-15 Thread Geert Uytterhoeven
On Wed, Jun 15, 2011 at 11:46, Arnd Bergmann wrote: > * In case of floppies, the "solution" was to write a driver for every > platform that >  doesn't have PIO, since they tend to have other differences. The amiflop and >  ataflop drivers are not even use readb(), they just derefence volatile >

Re: [RFC,PATCH] Cleanup PC parallel port Kconfig

2011-06-15 Thread Arnd Bergmann
On Wednesday 15 June 2011, H. Peter Anvin wrote: > On 06/14/2011 02:33 PM, Arnd Bergmann wrote: > >> > >> Why on earth restrict it like that? It's just a device driver, like > >> more or less any other device driver... > > > > I'd say any other classic ISA/PC driver, including floppy, gameport or

Re: [RFC,PATCH] Cleanup PC parallel port Kconfig

2011-06-15 Thread Ralf Baechle
On Tue, Jun 14, 2011 at 09:18:36PM -0700, H. Peter Anvin wrote: > On 06/14/2011 03:34 PM, Ralf Baechle wrote: > > > > There is no point in offering to build something that couldn't possibly be > > used. It just makes the kernel harder to configure and inflates the test > > matrix for no good rea

Re: [RFC,PATCH] Cleanup PC parallel port Kconfig

2011-06-15 Thread Lennox Wu
2011/6/15 Arnd Bergmann > > > config SCORE > > - def_bool y > > - select HAVE_GENERIC_HARDIRQS > > - select GENERIC_IRQ_SHOW > > + def_bool y > > + select HAVE_GENERIC_HARDIRQS > > + select HAVE_PC_PARPORT > > + select GENERIC_IRQ_SHOW > > > > choice > > p

Re: [RFC,PATCH] Cleanup PC parallel port Kconfig

2011-06-15 Thread Russell King - ARM Linux
On Tue, Jun 14, 2011 at 09:31:27PM -0700, H. Peter Anvin wrote: > On 06/14/2011 03:08 PM, Luck, Tony wrote: > > I took a look at the back of all my ia64 systems - none of them > > have a parallel port. It seems unlikely that new systems will > > start adding parallel ports :-) > > > > So even if

Re: [RFC,PATCH] Cleanup PC parallel port Kconfig

2011-06-15 Thread Russell King - ARM Linux
On Tue, Jun 14, 2011 at 09:30:47PM -0700, H. Peter Anvin wrote: > On 06/14/2011 02:33 PM, Arnd Bergmann wrote: > >> > >> Why on earth restrict it like that? It's just a device driver, like > >> more or less any other device driver... > > > > I'd say any other classic ISA/PC driver, including flop

Re: [RFC,PATCH] Cleanup PC parallel port Kconfig

2011-06-14 Thread H. Peter Anvin
On 06/14/2011 09:40 PM, Guenter Roeck wrote: > On Wed, Jun 15, 2011 at 12:18:36AM -0400, H. Peter Anvin wrote: >> On 06/14/2011 03:34 PM, Ralf Baechle wrote: >>> >>> There is no point in offering to build something that couldn't possibly be >>> used. It just makes the kernel harder to configure an

Re: [RFC,PATCH] Cleanup PC parallel port Kconfig

2011-06-14 Thread Guenter Roeck
On Wed, Jun 15, 2011 at 12:18:36AM -0400, H. Peter Anvin wrote: > On 06/14/2011 03:34 PM, Ralf Baechle wrote: > > > > There is no point in offering to build something that couldn't possibly be > > used. It just makes the kernel harder to configure and inflates the test > > matrix for no good reas

Re: [RFC,PATCH] Cleanup PC parallel port Kconfig

2011-06-14 Thread H. Peter Anvin
On 06/14/2011 03:08 PM, Luck, Tony wrote: > diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig > index 38280ef..849805a 100644 > --- a/arch/ia64/Kconfig > +++ b/arch/ia64/Kconfig > @@ -23,6 +23,7 @@ config IA64 > select HAVE_ARCH_TRACEHOOK > select HAVE_DMA_API_DEBUG > select HAVE

Re: [RFC,PATCH] Cleanup PC parallel port Kconfig

2011-06-14 Thread H. Peter Anvin
On 06/14/2011 02:33 PM, Arnd Bergmann wrote: >> >> Why on earth restrict it like that? It's just a device driver, like >> more or less any other device driver... > > I'd say any other classic ISA/PC driver, including floppy, gameport or > serial-8250. One problem with these is that we never fully

Re: [RFC,PATCH] Cleanup PC parallel port Kconfig

2011-06-14 Thread H. Peter Anvin
On 06/14/2011 03:34 PM, Ralf Baechle wrote: > > There is no point in offering to build something that couldn't possibly be > used. It just makes the kernel harder to configure and inflates the test > matrix for no good reason. > I see... that's why a bunch of devices that only exist on ARM and

Re: [RFC,PATCH] Cleanup PC parallel port Kconfig

2011-06-14 Thread Guan Xuetao
On Tue, 2011-06-14 at 20:08 +0100, Ralf Baechle wrote: > The PC parallel port Kconfig as acquired one of those messy terms to > describe it's architecture dependencies: > >depends on (!SPARC64 || PCI) && !SPARC32 && !M32R && !FRV && \ >(!M68K || ISA) && !MN10300 && !AVR32 &

Re: [RFC,PATCH] Cleanup PC parallel port Kconfig

2011-06-14 Thread Ralf Baechle
On Tue, Jun 14, 2011 at 01:25:46PM -0700, H. Peter Anvin wrote: > On 06/14/2011 12:08 PM, Ralf Baechle wrote: > > The PC parallel port Kconfig as acquired one of those messy terms to > > describe it's architecture dependencies: > > > >depends on (!SPARC64 || PCI) && !SPARC32 && !M32R && !

RE: [RFC,PATCH] Cleanup PC parallel port Kconfig

2011-06-14 Thread Luck, Tony
diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig index 38280ef..849805a 100644 --- a/arch/ia64/Kconfig +++ b/arch/ia64/Kconfig @@ -23,6 +23,7 @@ config IA64 select HAVE_ARCH_TRACEHOOK select HAVE_DMA_API_DEBUG select HAVE_GENERIC_HARDIRQS + select HAVE_PC_PARPORT

Re: [RFC,PATCH] Cleanup PC parallel port Kconfig

2011-06-14 Thread Arnd Bergmann
On Tuesday 14 June 2011 22:25:46 H. Peter Anvin wrote: > On 06/14/2011 12:08 PM, Ralf Baechle wrote: > > The PC parallel port Kconfig as acquired one of those messy terms to > > describe it's architecture dependencies: > > > >depends on (!SPARC64 || PCI) && !SPARC32 && !M32R && !FRV && \ >

Re: [RFC,PATCH] Cleanup PC parallel port Kconfig

2011-06-14 Thread H. Peter Anvin
On 06/14/2011 12:08 PM, Ralf Baechle wrote: > The PC parallel port Kconfig as acquired one of those messy terms to > describe it's architecture dependencies: > >depends on (!SPARC64 || PCI) && !SPARC32 && !M32R && !FRV && \ >(!M68K || ISA) && !MN10300 && !AVR32 && !BLACKFIN

Re: [RFC,PATCH] Cleanup PC parallel port Kconfig

2011-06-14 Thread Geert Uytterhoeven
On Tue, Jun 14, 2011 at 21:08, Ralf Baechle wrote: > The PC parallel port Kconfig as acquired one of those messy terms to > describe it's architecture dependencies: > >       depends on (!SPARC64 || PCI) && !SPARC32 && !M32R && !FRV && \ >               (!M68K || ISA) && !MN10300 && !AVR32 && !BLA

Re: [RFC,PATCH] Cleanup PC parallel port Kconfig

2011-06-14 Thread Arnd Bergmann
On Tuesday 14 June 2011 21:08:50 Ralf Baechle wrote: > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 9adc278..2968751f 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -21,6 +21,7 @@ config ARM > select HAVE_KERNEL_LZO > select HAVE_KERNEL_LZMA > select HA

[RFC,PATCH] Cleanup PC parallel port Kconfig

2011-06-14 Thread Ralf Baechle
The PC parallel port Kconfig as acquired one of those messy terms to describe it's architecture dependencies: depends on (!SPARC64 || PCI) && !SPARC32 && !M32R && !FRV && \ (!M68K || ISA) && !MN10300 && !AVR32 && !BLACKFIN This isn't just ugly - it also almost certainly desc