Re: [RESEND][PATCH][POWERPC] PIKA Warp: Update platform code to supportRev B boards

2008-04-29 Thread Josh Boyer
On Mon, 28 Apr 2008 18:07:17 -0400 Sean MacLennan <[EMAIL PROTECTED]> wrote: > On Mon, 28 Apr 2008 16:54:24 -0500 > Scott Wood <[EMAIL PROTECTED]> wrote: > > > Why can't the existing partition binding be used with NAND? It's > > what we do with Freescale FCM NAND. > > I guess I could put the pa

Re: [RESEND][PATCH][POWERPC] PIKA Warp: Update platform code to supportRev B boards

2008-04-28 Thread Grant Likely
On Mon, Apr 28, 2008 at 3:37 PM, Sean MacLennan <[EMAIL PROTECTED]> wrote: > On Mon, 28 Apr 2008 13:56:11 -0600 > > "Grant Likely" <[EMAIL PROTECTED]> wrote: > > > > > > You need to add the gpio-controller and #gpio-cells properties to the > > GPIO nodes for the LED's gpios property to work corre

Re: [RESEND][PATCH][POWERPC] PIKA Warp: Update platform code to supportRev B boards

2008-04-28 Thread Sean MacLennan
On Mon, 28 Apr 2008 16:54:24 -0500 Scott Wood <[EMAIL PROTECTED]> wrote: > Why can't the existing partition binding be used with NAND? It's > what we do with Freescale FCM NAND. I guess I could put the partitions in the dts. But I would have to read them and dynamically create an array to pass t

Re: [RESEND][PATCH][POWERPC] PIKA Warp: Update platform code to supportRev B boards

2008-04-28 Thread Scott Wood
On Mon, Apr 28, 2008 at 05:37:38PM -0400, Sean MacLennan wrote: > > Why is this information in the dts *and* the platform file? I haven't > > been following the flash partition map binding conventions, but having > > it in both places looks wrong > > > > oh, wait... the one in the dts is for

Re: [RESEND][PATCH][POWERPC] PIKA Warp: Update platform code to supportRev B boards

2008-04-28 Thread Sean MacLennan
On Mon, 28 Apr 2008 13:56:11 -0600 "Grant Likely" <[EMAIL PROTECTED]> wrote: > > You need to add the gpio-controller and #gpio-cells properties to the > GPIO nodes for the LED's gpios property to work correctly. Search for > "2) gpio-controller nodes" in > Documentation/powerpc/booting-without-o

Re: [RESEND][PATCH][POWERPC] PIKA Warp: Update platform code to supportRev B boards

2008-04-28 Thread Richard Purdie
On Mon, 2008-04-28 at 13:59 -0400, Sean MacLennan wrote: > On Mon, 28 Apr 2008 11:44:19 -0600 > "Grant Likely" <[EMAIL PROTECTED]> wrote: > > > This looks appropriate. You'll need to make sure that the values in > > the linux,name property meet the Linux LED naming guidelines. I think > > this

Re: [RESEND][PATCH][POWERPC] PIKA Warp: Update platform code to supportRev B boards

2008-04-28 Thread Grant Likely
On Mon, Apr 28, 2008 at 12:53 PM, Sean MacLennan <[EMAIL PROTECTED]> wrote: > Ok, here is another version of the patch with Stephen Rothwell's and > Grant Likely's suggestions. > > Cheers, > Sean A few more comments below. Also, it might help to split up the .dts and code changes into 2 separ

Re: [RESEND][PATCH][POWERPC] PIKA Warp: Update platform code to supportRev B boards

2008-04-28 Thread Sean MacLennan
Ok, here is another version of the patch with Stephen Rothwell's and Grant Likely's suggestions. Cheers, Sean PIKA Warp: Update platform code to support Rev B boards. * Switched from 64M NOR/64M NAND to 4M NOR/256M NAND. * Full DTM support including critical temperature. * Added POST informatio

Re: [RESEND][PATCH][POWERPC] PIKA Warp: Update platform code to supportRev B boards

2008-04-28 Thread Sean MacLennan
On Mon, 28 Apr 2008 11:44:19 -0600 "Grant Likely" <[EMAIL PROTECTED]> wrote: > This looks appropriate. You'll need to make sure that the values in > the linux,name property meet the Linux LED naming guidelines. I think > this is covered in Documentation/leds-class.c. You can also as > Richard P

Re: [RESEND][PATCH][POWERPC] PIKA Warp: Update platform code to supportRev B boards

2008-04-28 Thread Grant Likely
On Mon, Apr 28, 2008 at 11:10 AM, Sean MacLennan <[EMAIL PROTECTED]> wrote: > On Sun, 27 Apr 2008 22:47:43 -0600 > > "Grant Likely" <[EMAIL PROTECTED]> wrote: > > > > If your LEDs are attached to gpio pins, then you should use the > > current draft led->gpio bindings as shown in the above patch.

Re: [RESEND][PATCH][POWERPC] PIKA Warp: Update platform code to supportRev B boards

2008-04-28 Thread Sean MacLennan
On Sun, 27 Apr 2008 22:47:43 -0600 "Grant Likely" <[EMAIL PROTECTED]> wrote: > If your LEDs are attached to gpio pins, then you should use the > current draft led->gpio bindings as shown in the above patch. Then, > let your platform code extract whatever data it needs from the device > tree to se

Re: [RESEND][PATCH][POWERPC] PIKA Warp: Update platform code to supportRev B boards

2008-04-27 Thread Grant Likely
On Sun, Apr 27, 2008 at 8:25 PM, Sean MacLennan <[EMAIL PROTECTED]> wrote: > On Sun, 27 Apr 2008 19:51:57 -0600 > "Grant Likely" <[EMAIL PROTECTED]> wrote: > > > Actually, it looks like he's trying to find the second gpio node in > > the tree. > > Correct. > > > > Sean, if that is true, then t

Re: [RESEND][PATCH][POWERPC] PIKA Warp: Update platform code to supportRev B boards

2008-04-27 Thread Sean MacLennan
On Mon, 28 Apr 2008 10:58:59 +1000 "Stephen Rothwell" <[EMAIL PROTECTED]> wrote: > You really want linux.of.h (unless there was some preexisting reason > to require of_platform.h). You are correct. That was a cut and paste from warp.c which specifically needs of_platform.h. Cheers, Sean _

Re: [RESEND][PATCH][POWERPC] PIKA Warp: Update platform code to supportRev B boards

2008-04-27 Thread Sean MacLennan
On Sun, 27 Apr 2008 19:51:57 -0600 "Grant Likely" <[EMAIL PROTECTED]> wrote: > Actually, it looks like he's trying to find the second gpio node in > the tree. Correct. > Sean, if that is true, then this is a very fragile way to do it. > Really, you should have a phandle somewhere that points to

Re: [RESEND][PATCH][POWERPC] PIKA Warp: Update platform code to supportRev B boards

2008-04-27 Thread Grant Likely
On Sun, Apr 27, 2008 at 6:58 PM, Stephen Rothwell <[EMAIL PROTECTED]> wrote: > Hi Sean, > > > On Sun, 27 Apr 2008 15:25:46 -0400 Sean MacLennan <[EMAIL PROTECTED]> wrote: > > > > +++ b/arch/powerpc/platforms/44x/warp-nand.c > > @@ -11,8 +11,10 @@ > > #include > > #include > > #include

Re: [RESEND][PATCH][POWERPC] PIKA Warp: Update platform code to supportRev B boards

2008-04-27 Thread Stephen Rothwell
Hi Sean, On Sun, 27 Apr 2008 15:25:46 -0400 Sean MacLennan <[EMAIL PROTECTED]> wrote: > > +++ b/arch/powerpc/platforms/44x/warp-nand.c > @@ -11,8 +11,10 @@ > #include > #include > #include > +#include You really want linux.of.h (unless there was some preexisting reason to require of_platfo

Re: [RESEND][PATCH][POWERPC] PIKA Warp: Update platform code to supportRev B boards

2008-04-27 Thread Sean MacLennan
Update. HW decided that the panic was bad. Added a flashing led to the critical temperature. Cheers, Sean PIKA Warp: Update platform code to support Rev B boards. * Switched from 64M NOR/64M NAND to 4M NOR/256M NAND. * Full DTM support including critical temperature. * Added POST information.