On Mon, 17 Mar 2008 17:38:21 -0500
Scott Wood wrote:
> On Sun, Mar 09, 2008 at 07:59:14PM +0300, Vitaly Bordug wrote:
> > I would like all the comments to be consistent C style (because
> > that's it for the most other dts'es).
>
> $ fgrep -rI // arch/powerpc/boot/dts/ | wc -l
> 539
>
So, we sho
On Sun, Mar 09, 2008 at 07:59:14PM +0300, Vitaly Bordug wrote:
> I would like all the comments to be consistent C style (because that's it
> for the most other dts'es).
$ fgrep -rI // arch/powerpc/boot/dts/ | wc -l
539
-Scott
___
Linuxppc-dev mailing li
Hi,
On Mon, 10 Mar 2008 07:34:46 +0100 Heiko Schocher <[EMAIL PROTECTED]> wrote:
>
> >> +static struct of_device_id __initdata of_bus_ids[] = {
> >
> > Make this __initdata, please.
>
> Hmm.. it is __initdata, or? But I fix it to:
OOPS, brain not working again after break :-)
sorry.
> static
Hello Stephen,
Stephen Rothwell wrote:
> On Sun, 09 Mar 2008 10:56:29 +0100 Heiko Schocher <[EMAIL PROTECTED]> wrote:
>> +++ b/arch/powerpc/platforms/8xx/mgsuvd.c
>>
>> +#include
>
> You should include linux/of_platform.h (not asm/)
Ok.
>> +static struct cpm_pin mgsuvd_pins[] = {
>
> Make thi
Hello Vitaly,
Vitaly Bordug wrote:
> Heiko Schocher wrote:
>> the following patch adds support for the MPC852 based mgsuvd board
>> from keymile.
> Looks good overall. Please add supported/working/not working etc SoC devices
> state along with the patch
> description. Also a few really small com
Hi Heiko,
Just a few small comments.
On Sun, 09 Mar 2008 10:56:29 +0100 Heiko Schocher <[EMAIL PROTECTED]> wrote:
>
> +++ b/arch/powerpc/platforms/8xx/mgsuvd.c
>
> +#include
You should include linux/of_platform.h (not asm/)
> +static struct cpm_pin mgsuvd_pins[] = {
Make this __initdata, plea
Heiko,
On Sun, 09 Mar 2008 10:56:29 +0100
Heiko Schocher wrote:
> Hello,
>
> the following patch adds support for the MPC852 based mgsuvd board
> from keymile.
Looks good overall. Please add supported/working/not working etc SoC devices
state along with the patch
description. Also a few really
Hello,
the following patch adds support for the MPC852 based mgsuvd board
from keymile.
Signed-off-by: Heiko Schocher <[EMAIL PROTECTED]>
---
arch/powerpc/boot/dts/mgsuvd.dts | 158 +++
arch/powerpc/configs/mgsuvd_defconfig | 827 +
arch/powerpc/platfor
