Heiko,
On Sun, 09 Mar 2008 10:56:29 +0100
Heiko Schocher wrote:
> Hello,
>
> the following patch adds support for the MPC852 based mgsuvd board
> from keymile.
Looks good overall. Please add supported/working/not working etc SoC devices
state along with the patch
description. Also a few really small comments below...
>
> Signed-off-by: Heiko Schocher <[EMAIL PROTECTED]>
> ---
> arch/powerpc/boot/dts/mgsuvd.dts | 158 +++++++
> arch/powerpc/configs/mgsuvd_defconfig | 827
> +++++++++++++++++++++++++++++++++
> arch/powerpc/platforms/8xx/Kconfig | 7 +
> arch/powerpc/platforms/8xx/Makefile | 1 +
> arch/powerpc/platforms/8xx/mgsuvd.c | 138 ++++++ 5 files changed,
> 1131 insertions(+), 0 deletions(-) create mode 100644
> arch/powerpc/boot/dts/mgsuvd.dts create mode 100644
> arch/powerpc/configs/mgsuvd_defconfig create mode 100644
> arch/powerpc/platforms/8xx/mgsuvd.c
>
> diff --git a/arch/powerpc/boot/dts/mgsuvd.dts
> b/arch/powerpc/boot/dts/mgsuvd.dts new file mode 100644
> index 0000000..629cb6d
> --- /dev/null
> +++ b/arch/powerpc/boot/dts/mgsuvd.dts
> @@ -0,0 +1,158 @@
> +/*
> + * MGSUVD Device Tree Source
> + *
> + * Copyright 2008 DENX Software Engineering GmbH
> + * Heiko Schocher <[EMAIL PROTECTED]>
> + *
> + * This program is free software; you can redistribute it and/or
> modify it
> + * under the terms of the GNU General Public License as published
> by the
> + * Free Software Foundation; either version 2 of the License, or
> (at your
> + * option) any later version.
> + */
> +
> +
> +/ {
> + model = "MGSUVD";
> + compatible = "keymile,mgsuvd";
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + cpus {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + PowerPC,[EMAIL PROTECTED] {
But it's mpc852, isn't it?
> + device_type = "cpu";
> + reg = <0>;
> + d-cache-line-size = <d#16>;
> + i-cache-line-size = <d#16>;
> + d-cache-size = <d#8192>;
> + i-cache-size = <d#8192>;
> + timebase-frequency = <0>; /* Filled in by
> u-boot */
> + bus-frequency = <0>; /* Filled in by u-boot
> */
> + clock-frequency = <0>; /* Filled in by
> u-boot */
> + interrupts = <f 2>; // decrementer
> interrupt
I would like all the comments to be consistent C style (because that's it for
the most other dts'es).
[....]
--
Sincerely, Vitaly
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
