Re: [PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP_MAYSLEEP

2025-03-15 Thread George Cherian
Hi Julius, >> static const struct watchdog_ops adv_ec_wdt_ops = { >> diff --git a/drivers/watchdog/arm_smc_wdt.c b/drivers/watchdog/arm_smc_wdt.c >> index 8f3d0c3a005f..794cf0086912 100644 >> --- a/drivers/watchdog/arm_smc_wdt.c >> +++ b/drivers/watchdog/arm_smc_wdt.c >> @@ -90,7 +90,8 @@ static c

Re: [EXTERNAL] Re: [PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP_MAYSLEEP

2025-03-06 Thread Guenter Roeck
On Thu, Mar 06, 2025 at 12:18:20PM +, George Cherian wrote: > Hi Guenter, > > I am summarizing the topics we discussed in multiple threads here. > > >>On 3/5/25 03:01, Ahmad Fatoum wrote: > >> Hi George, > >> Hi Guenter, > >> > >> On 05.03.25 11:34, George Cherian wrote: > why is armada

RE: [EXTERNAL] Re: [PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP_MAYSLEEP

2025-03-06 Thread George Cherian
Hi Guenter, I am summarizing the topics we discussed in multiple threads here. >>On 3/5/25 03:01, Ahmad Fatoum wrote: >> Hi George, >> Hi Guenter, >> >> On 05.03.25 11:34, George Cherian wrote: why is armada_37xx_wdt also here? The stop function in that driver may not sleep. >>> Marek,

Re: [PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP_MAYSLEEP

2025-03-05 Thread Guenter Roeck
On 3/5/25 03:01, Ahmad Fatoum wrote: Hi George, Hi Guenter, On 05.03.25 11:34, George Cherian wrote: why is armada_37xx_wdt also here? The stop function in that driver may not sleep. Marek, Thanks for reviewing. Since the stop function has a regmap_write(), I thought it might sleep. Now that

Re: [PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP_MAYSLEEP

2025-03-05 Thread Julius Werner
> static const struct watchdog_ops adv_ec_wdt_ops = { > diff --git a/drivers/watchdog/arm_smc_wdt.c b/drivers/watchdog/arm_smc_wdt.c > index 8f3d0c3a005f..794cf0086912 100644 > --- a/drivers/watchdog/arm_smc_wdt.c > +++ b/drivers/watchdog/arm_smc_wdt.c > @@ -90,7 +90,8 @@ static const struct watch

Re: [PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP_MAYSLEEP

2025-03-05 Thread Guenter Roeck
On 3/5/25 02:10, George Cherian wrote: A new option flag is added to watchdog_info. This helps the watchdog core to check whether stop functions would sleep or not. The option flags of individual drivers are also updated accordingly. Signed-off-by: George Cherian --- drivers/watchdog/advantec

Re: [PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP_MAYSLEEP

2025-03-05 Thread George Cherian
: Re: [PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP_MAYSLEEP > Hi George, > > why is armada_37xx_wdt also here? > The stop function in that driver may not sleep. Marek, Thanks for reviewing. Since the stop function has a regmap_write(), I thought it might sleep. Now that you point

Re: [PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP_MAYSLEEP

2025-03-05 Thread Andy Shevchenko
On Wed, Mar 05, 2025 at 10:10:24AM +, George Cherian wrote: > A new option flag is added to watchdog_info. This helps the watchdog > core to check whether stop functions would sleep or not. > The option flags of individual drivers are also updated accordingly. ... > .options = WDIO

[PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP_MAYSLEEP

2025-03-05 Thread George Cherian
A new option flag is added to watchdog_info. This helps the watchdog core to check whether stop functions would sleep or not. The option flags of individual drivers are also updated accordingly. Signed-off-by: George Cherian --- drivers/watchdog/advantech_ec_wdt.c | 3 ++- drivers/watchdog/arm_s

Re: [PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP_MAYSLEEP

2025-03-05 Thread Ahmad Fatoum
Hi George, Hi Guenter, On 05.03.25 11:34, George Cherian wrote: >> why is armada_37xx_wdt also here? >> The stop function in that driver may not sleep. > Marek, > > Thanks for reviewing. > Since the stop function has a regmap_write(), I thought it might sleep. > Now that you pointed it out, I ass

Re: [PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP_MAYSLEEP

2025-03-05 Thread Marek BehĂșn
Hi George, why is armada_37xx_wdt also here? The stop function in that driver may not sleep. Marek