Re: [PATCH v3 02/18] KVM: PPC: Use RCU when adding to arch.spapr_tce_tables

2014-07-27 Thread Benjamin Herrenschmidt
On Mon, 2014-07-28 at 14:11 +1000, Alexey Kardashevskiy wrote: > === > At the moment the spapr_tce_tables list is not protected against races > which may happen if the userspace issues the KVM_CREATE_SPAPR_TCE ioctl > to KVM from different threads. > > This makes use of _rcu helpers for list_add()

Re: [PATCH v3 02/18] KVM: PPC: Use RCU when adding to arch.spapr_tce_tables

2014-07-27 Thread Alexey Kardashevskiy
On 07/28/2014 10:40 AM, Benjamin Herrenschmidt wrote: > On Thu, 2014-07-24 at 18:47 +1000, Alexey Kardashevskiy wrote: >> Signed-off-by: Alexey Kardashevskiy >> Reviewed-by: Gavin Shan > > You need a much better changeset here, explaining what you are > protecting against and why just changing t

Re: [PATCH v3 02/18] KVM: PPC: Use RCU when adding to arch.spapr_tce_tables

2014-07-27 Thread Benjamin Herrenschmidt
On Thu, 2014-07-24 at 18:47 +1000, Alexey Kardashevskiy wrote: > Signed-off-by: Alexey Kardashevskiy > Reviewed-by: Gavin Shan You need a much better changeset here, explaining what you are protecting against and why just changing that one list_add is sufficient. Cheers, Ben. > --- > arch/pow

[PATCH v3 02/18] KVM: PPC: Use RCU when adding to arch.spapr_tce_tables

2014-07-24 Thread Alexey Kardashevskiy
Signed-off-by: Alexey Kardashevskiy Reviewed-by: Gavin Shan --- arch/powerpc/kvm/book3s_64_vio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kvm/book3s_64_vio.c b/arch/powerpc/kvm/book3s_64_vio.c index 54cf9bc..516f2ee 100644 --- a/arch/powerpc/kvm/book3s_64_