Re: [PATCH v2.6.26] powerpc: Fix a bunch of sparse warnings in the qe_lib

2008-05-02 Thread Andy Fleming
On May 2, 2008, at 13:37, Timur Tabi wrote: Andy Fleming wrote: int ucc_fast_init(struct ucc_fast_info * uf_info, struct ucc_fast_private ** uccf_ret) { struct ucc_fast_private *uccf; - struct ucc_fast *uf_regs; + struct ucc_fast __iomem *uf_regs; u32 gumr;

Re: [PATCH v2.6.26] powerpc: Fix a bunch of sparse warnings in the qe_lib

2008-05-02 Thread Andy Fleming
On May 2, 2008, at 13:07, Scott Wood wrote: Andy Fleming wrote: + struct qe_iram __iomem iram; /* I-RAM */ + struct qe_ic_regs __iomem ic; /* Interrupt Controller */ + struct cp_qe __iomemcp; /* Communications Processor */ + struct q

Re: [PATCH v2.6.26] powerpc: Fix a bunch of sparse warnings in the qe_lib

2008-05-02 Thread Timur Tabi
Andy Fleming wrote: > int ucc_fast_init(struct ucc_fast_info * uf_info, struct ucc_fast_private ** > uccf_ret) > { > struct ucc_fast_private *uccf; > - struct ucc_fast *uf_regs; > + struct ucc_fast __iomem *uf_regs; > u32 gumr; > int ret; > > @@ -216,10 +216,10 @@ in

Re: [PATCH v2.6.26] powerpc: Fix a bunch of sparse warnings in the qe_lib

2008-05-02 Thread Scott Wood
Andy Fleming wrote: + struct qe_iram __iomem iram; /* I-RAM */ + struct qe_ic_regs __iomem ic; /* Interrupt Controller */ + struct cp_qe __iomemcp; /* Communications Processor */ + struct qe_mux __iomem qmx;/* QE Multiplex

[PATCH v2.6.26] powerpc: Fix a bunch of sparse warnings in the qe_lib

2008-05-02 Thread Andy Fleming
Mostly having to do with not marking things __iomem. And some failure to use appropriate accessors to read MMIO regs. Signed-off-by: Andy Fleming <[EMAIL PROTECTED]> --- arch/powerpc/sysdev/qe_lib/qe.c |6 ++-- arch/powerpc/sysdev/qe_lib/ucc.c |6 ++-- arch/powerpc/sysdev/qe_l