On May 2, 2008, at 13:37, Timur Tabi wrote:

Andy Fleming wrote:

int ucc_fast_init(struct ucc_fast_info * uf_info, struct ucc_fast_private ** uccf_ret)
{
        struct ucc_fast_private *uccf;
-       struct ucc_fast *uf_regs;
+       struct ucc_fast __iomem *uf_regs;
        u32 gumr;
        int ret;

@@ -216,10 +216,10 @@ int ucc_fast_init(struct ucc_fast_info * uf_info, struct ucc_fast_private ** ucc
        uccf->stopped_tx = 0;
        uccf->stopped_rx = 0;
        uf_regs = uccf->uf_regs;
-       uccf->p_ucce = (u32 *) & (uf_regs->ucce);
-       uccf->p_uccm = (u32 *) & (uf_regs->uccm);
+       uccf->p_ucce = (u32 __iomem *) & (uf_regs->ucce);
+       uccf->p_uccm = (u32 __iomem *) & (uf_regs->uccm);

Since you've already made uf_regs into an __iomem pointer, do you really need to
cast it?

Ah, yes.  That's probably leftover from when uf_regs wasn't __iomem.



And please remember to CC: me on any QE library patches.

Can do.

Andy
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to