> On 10/15/07, Matt Sealey <[EMAIL PROTECTED]> wrote:
>>
>> My nits:
>>
>> Grant Likely wrote:
>> > From: Sylvain Munaut <[EMAIL PROTECTED]>
>> > +static int __devinit
>> > +bcom_engine_init(void)
>>
>> Why "bcom" and not "bestcomm"?
>
> I can type 'bcom' twice as fast. :-) bcom is a suitable sho
On 10/15/07, Matt Sealey <[EMAIL PROTECTED]> wrote:
>
> Grant Likely wrote:
> > On 10/15/07, Matt Sealey <[EMAIL PROTECTED]> wrote:
> >> My nits:
> >>
> >> Grant Likely wrote:
> >>> From: Sylvain Munaut <[EMAIL PROTECTED]>
> >>> +static int __devinit
> >>> +bcom_engine_init(void)
> >> Why "bcom" an
Matt Sealey wrote:
> call a PSC, we wouldn't be making structures called
> mpc52xx_programmable_serial_controller,
> that's redundant, I don't think calling it "bestcomm" (which is it's name)
> over
> "bcom" (which isn't) works to anyone's advantage here.
Disadvantage, even. Damn autocorrectin
Grant Likely wrote:
> On 10/15/07, Matt Sealey <[EMAIL PROTECTED]> wrote:
>> My nits:
>>
>> Grant Likely wrote:
>>> From: Sylvain Munaut <[EMAIL PROTECTED]>
>>> +static int __devinit
>>> +bcom_engine_init(void)
>> Why "bcom" and not "bestcomm"?
>
> I can type 'bcom' twice as fast. :-) bcom is a
Grant Likely wrote:
> On 10/15/07, Kumar Gala <[EMAIL PROTECTED]> wrote:
>> (Comments just on SRAM code)
>>
>> I think this should be made generic and be utility functionality to
>> rheap.
>>
>> CPM, CPM2, QE, L2 SRAM, etc can all use this. I'd rather we didn't
>> have 3 ways to do the exact same
On 10/15/07, Kumar Gala <[EMAIL PROTECTED]> wrote:
> (Comments just on SRAM code)
>
> I think this should be made generic and be utility functionality to
> rheap.
>
> CPM, CPM2, QE, L2 SRAM, etc can all use this. I'd rather we didn't
> have 3 ways to do the exact same functionality. (cpm_dpalloc,
(Comments just on SRAM code)
I think this should be made generic and be utility functionality to
rheap.
CPM, CPM2, QE, L2 SRAM, etc can all use this. I'd rather we didn't
have 3 ways to do the exact same functionality. (cpm_dpalloc,
cpm_dpfree, qe_muram_alloc, qe_muram_free)
see other co
On 10/15/07, Matt Sealey <[EMAIL PROTECTED]> wrote:
>
> My nits:
>
> Grant Likely wrote:
> > From: Sylvain Munaut <[EMAIL PROTECTED]>
> > +static int __devinit
> > +bcom_engine_init(void)
>
> Why "bcom" and not "bestcomm"?
I can type 'bcom' twice as fast. :-) bcom is a suitable shortening;
I'm n
My nits:
Grant Likely wrote:
> From: Sylvain Munaut <[EMAIL PROTECTED]>
> +static int __devinit
> +bcom_engine_init(void)
Why "bcom" and not "bestcomm"?
> + /* Disable COMM Bus Prefetch, apparently it's not reliable yet */
> + /* FIXME: This should be done on 5200 and not 5200B ... */
>
On Sun, Oct 14, 2007 at 03:23:21PM -0600, Grant Likely wrote:
> On 10/14/07, Sven Luther <[EMAIL PROTECTED]> wrote:
> > On Sun, Oct 14, 2007 at 02:22:16PM -0600, Grant Likely wrote:
> > > On 10/14/07, Sven Luther <[EMAIL PROTECTED]> wrote:
> > > > On Sat, Oct 13, 2007 at 10:42:05PM -0600, Grant Lik
On 10/14/07, Sven Luther <[EMAIL PROTECTED]> wrote:
> On Sun, Oct 14, 2007 at 02:22:16PM -0600, Grant Likely wrote:
> > On 10/14/07, Sven Luther <[EMAIL PROTECTED]> wrote:
> > > On Sat, Oct 13, 2007 at 10:42:05PM -0600, Grant Likely wrote:
> > > > From: Sylvain Munaut <[EMAIL PROTECTED]>
> > > >
>
On Sun, Oct 14, 2007 at 02:22:16PM -0600, Grant Likely wrote:
> On 10/14/07, Sven Luther <[EMAIL PROTECTED]> wrote:
> > On Sat, Oct 13, 2007 at 10:42:05PM -0600, Grant Likely wrote:
> > > From: Sylvain Munaut <[EMAIL PROTECTED]>
> > >
> > > This patch adds support for the core of the BestComm API
>
On 10/14/07, Sven Luther <[EMAIL PROTECTED]> wrote:
> On Sat, Oct 13, 2007 at 10:42:05PM -0600, Grant Likely wrote:
> > From: Sylvain Munaut <[EMAIL PROTECTED]>
> >
> > This patch adds support for the core of the BestComm API
> > for the Freescale MPC5200(b). The BestComm engine is a
> > microcode-
On Sat, Oct 13, 2007 at 10:42:05PM -0600, Grant Likely wrote:
> From: Sylvain Munaut <[EMAIL PROTECTED]>
>
> This patch adds support for the core of the BestComm API
> for the Freescale MPC5200(b). The BestComm engine is a
> microcode-controlled / tasks-based DMA used by several
> of the onchip de
From: Sylvain Munaut <[EMAIL PROTECTED]>
This patch adds support for the core of the BestComm API
for the Freescale MPC5200(b). The BestComm engine is a
microcode-controlled / tasks-based DMA used by several
of the onchip devices.
Setting up the tasks / memory allocation and all common
low level
15 matches
Mail list logo
