Re: [PATCH v2 2/4] [libata] pata_of_platform: OF-Platform PATA device driver

2007-12-14 Thread Olof Johansson
On Fri, Dec 14, 2007 at 10:09:28AM -0600, Scott Wood wrote: > On Fri, Dec 14, 2007 at 02:23:13AM -0600, Olof Johansson wrote: > > On Wed, Dec 05, 2007 at 12:39:12PM -0600, Scott Wood wrote: > > > Why is it dependent on anything other than platform bus support and ATA? > > > > There's no way to spe

Re: [PATCH v2 2/4] [libata] pata_of_platform: OF-Platform PATA device driver

2007-12-14 Thread Scott Wood
On Fri, Dec 14, 2007 at 02:23:13AM -0600, Olof Johansson wrote: > On Wed, Dec 05, 2007 at 12:39:12PM -0600, Scott Wood wrote: > > Why is it dependent on anything other than platform bus support and ATA? > > There's no way to specify dependency on platform bus as a config option, > that's likely wh

Re: [PATCH v2 2/4] [libata] pata_of_platform: OF-Platform PATA device driver

2007-12-14 Thread Olof Johansson
On Wed, Dec 05, 2007 at 12:39:12PM -0600, Scott Wood wrote: > On Wed, Dec 05, 2007 at 09:48:41AM +0900, Paul Mundt wrote: > > On Tue, Dec 04, 2007 at 02:01:21PM -0600, Olof Johansson wrote: > > > On Tue, Dec 04, 2007 at 10:49:21PM +0300, Anton Vorontsov wrote: > > > > tristate "Generic plat

Re: [PATCH v2 2/4] [libata] pata_of_platform: OF-Platform PATA device driver

2007-12-05 Thread Scott Wood
On Wed, Dec 05, 2007 at 09:48:41AM +0900, Paul Mundt wrote: > On Tue, Dec 04, 2007 at 02:01:21PM -0600, Olof Johansson wrote: > > On Tue, Dec 04, 2007 at 10:49:21PM +0300, Anton Vorontsov wrote: > > > tristate "Generic platform device PATA support" > > > - depends on EMBEDDED || ARCH_RPC > > > +

Re: [PATCH v2 2/4] [libata] pata_of_platform: OF-Platform PATA device driver

2007-12-04 Thread Olof Johansson
On Wed, Dec 05, 2007 at 09:48:41AM +0900, Paul Mundt wrote: > On Tue, Dec 04, 2007 at 02:01:21PM -0600, Olof Johansson wrote: > > On Tue, Dec 04, 2007 at 10:49:21PM +0300, Anton Vorontsov wrote: > > > tristate "Generic platform device PATA support" > > > - depends on EMBEDDED || ARCH_RPC > > > +

Re: [PATCH v2 2/4] [libata] pata_of_platform: OF-Platform PATA device driver

2007-12-04 Thread Paul Mundt
On Tue, Dec 04, 2007 at 02:01:21PM -0600, Olof Johansson wrote: > On Tue, Dec 04, 2007 at 10:49:21PM +0300, Anton Vorontsov wrote: > > tristate "Generic platform device PATA support" > > - depends on EMBEDDED || ARCH_RPC > > + depends on EMBEDDED || ARCH_PPC > > It needs to be || PPC, not

Re: [PATCH v2 2/4] [libata] pata_of_platform: OF-Platform PATA device driver

2007-12-04 Thread Olof Johansson
On Tue, Dec 04, 2007 at 11:37:51PM +0300, Anton Vorontsov wrote: > On Tue, Dec 04, 2007 at 02:01:21PM -0600, Olof Johansson wrote: > > On Tue, Dec 04, 2007 at 10:49:21PM +0300, Anton Vorontsov wrote: > > > tristate "Generic platform device PATA support" > > > - depends on EMBEDDED || ARCH_RPC > >

Re: [PATCH v2 2/4] [libata] pata_of_platform: OF-Platform PATA device driver

2007-12-04 Thread Anton Vorontsov
On Tue, Dec 04, 2007 at 02:01:21PM -0600, Olof Johansson wrote: > On Tue, Dec 04, 2007 at 10:49:21PM +0300, Anton Vorontsov wrote: > > tristate "Generic platform device PATA support" > > - depends on EMBEDDED || ARCH_RPC > > + depends on EMBEDDED || ARCH_PPC > > It needs to be || PPC, not

Re: [PATCH v2 2/4] [libata] pata_of_platform: OF-Platform PATA device driver

2007-12-04 Thread Olof Johansson
On Tue, Dec 04, 2007 at 10:49:21PM +0300, Anton Vorontsov wrote: > tristate "Generic platform device PATA support" > - depends on EMBEDDED || ARCH_RPC > + depends on EMBEDDED || ARCH_PPC It needs to be || PPC, not || ARCH_PPC. -Olof ___

Re: [PATCH v2 2/4] [libata] pata_of_platform: OF-Platform PATA device driver

2007-12-04 Thread Anton Vorontsov
On Tue, Dec 04, 2007 at 12:48:26PM -0600, Olof Johansson wrote: > Hi, > > On Tue, Dec 04, 2007 at 08:07:19PM +0300, Anton Vorontsov wrote: > > This driver nicely wraps around pata_platform library functions, [..] > There's a typo in the dependencies for PATA_PLATFORM that you should change: > > d

Re: [PATCH v2 2/4] [libata] pata_of_platform: OF-Platform PATA device driver

2007-12-04 Thread Olof Johansson
Hi, On Tue, Dec 04, 2007 at 08:07:19PM +0300, Anton Vorontsov wrote: > This driver nicely wraps around pata_platform library functions, > and provides OF platform bus bindings to the PATA devices. > > Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> > --- > drivers/ata/Kconfig| 1

[PATCH v2 2/4] [libata] pata_of_platform: OF-Platform PATA device driver

2007-12-04 Thread Anton Vorontsov
This driver nicely wraps around pata_platform library functions, and provides OF platform bus bindings to the PATA devices. Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> --- drivers/ata/Kconfig| 10 drivers/ata/Makefile |1 + drivers/ata/pata_of_platform.c |