Hi,
On Tue, Dec 04, 2007 at 08:07:19PM +0300, Anton Vorontsov wrote:
> This driver nicely wraps around pata_platform library functions,
> and provides OF platform bus bindings to the PATA devices.
>
> Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
> ---
> drivers/ata/Kconfig | 10 ++++
> drivers/ata/Makefile | 1 +
> drivers/ata/pata_of_platform.c | 102
> ++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 113 insertions(+), 0 deletions(-)
> create mode 100644 drivers/ata/pata_of_platform.c
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index ba63619..5a492fa 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -614,6 +614,16 @@ config PATA_PLATFORM
>
> If unsure, say N.
>
> +config PATA_OF_PLATFORM
> + tristate "OpenFirmware platform device PATA support"
> + depends on PATA_PLATFORM && PPC_OF
> + help
> + This option enables support for generic directly connected ATA
> + devices commonly found on embedded systems with OpenFirmware
> + bindings.
> +
> + If unsure, say N.
> +
There's a typo in the dependencies for PATA_PLATFORM that you should change:
depends on EMBEDDED || ARCH_RPC
(note ARCH_>R<PC). With my font it's hard to tell a difference :)
It should really be:
depends on EMBEDDED || PPC
Care to change that while you're at it?
> +static struct of_device_id pata_of_platform_match[] = {
> + { .compatible = "ata-generic", },
> +};
Needs to be terminated by empty entry, and please add:
MODULE_DEVICE_TABLE(of, pata_of_platform_match);
-Olof
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
