Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-15 Thread Scott Wood
;> d...@lists.ozlabs.org >> Subject: Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie >> initialization code >> >> On 08/10/2012 03:47 AM, Jia Hongtao-B38951 wrote: >>> >>> >>>> -Original Message- >>>> From: Gala Kumar-B117

RE: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-15 Thread Jia Hongtao-B38951
t; >> Cc: Jia Hongtao-B38951; Wood Scott-B07421; Li Yang-R58472; linuxppc- > >> d...@lists.ozlabs.org > >> Subject: Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie > >> initialization code > >> > >>>>>>>>> As I explained before,

Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-10 Thread Scott Wood
;> d...@lists.ozlabs.org >> Subject: Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie >> initialization code >> >>>>>>>>> As I explained before, this has to be done globally, not from >>>>>>>>> the probe function, so we can assig

RE: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-10 Thread Jia Hongtao-B38951
> -Original Message- > From: Gala Kumar-B11780 > Sent: Thursday, August 09, 2012 3:04 AM > To: Wood Scott-B07421 > Cc: Jia Hongtao-B38951; Wood Scott-B07421; Li Yang-R58472; linuxppc- > d...@lists.ozlabs.org > Subject: Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/

Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-09 Thread Scott Wood
el.crashing.org; Li Yang-R58472 >> Subject: Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie >> initialization code >> >> On 08/08/2012 04:39 AM, Jia Hongtao-B38951 wrote: >>> >>> >>>> -Original Message- >>>> From: Wood Scot

Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-09 Thread Scott Wood
>> Gala Kumar-B11780 >> Subject: Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie >> initialization code >> >> On 08/08/2012 04:03 AM, Jia Hongtao-B38951 wrote: >>> >>> >>>> -Original Message- >>>> From: Wood Scott-B07421 &

RE: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-08 Thread Jia Hongtao-B38951
t; Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org; > >> ga...@kernel.crashing.org; Li Yang-R58472 > >> Subject: Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie > >> initialization code > >> > >> On 08/07/2012 03:09 AM, Jia Hongtao-B38951 wrote

RE: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-08 Thread Jia Hongtao-B38951
ott-B07421; linuxppc-dev@lists.ozlabs.org; Li Yang-R58472; > >> Jia > >> Hongtao-B38951 > >> Subject: Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie > >> initialization code > >> > >> On 08/06/2012 11:20 PM

Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-08 Thread Gala Kumar-B11780
>>> As I explained before, this has to be done globally, not from the >>> probe function, so we can assign a default primary bus if there >>> isn't any ISA. >>> There are bugs in the Linux PPC PCI code relating to not having >>> any primary bus. >>> >>> -Scott >> >

Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-08 Thread Scott Wood
rashing.org; Li Yang-R58472 >> Subject: Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie >> initialization code >> >> On 08/07/2012 03:09 AM, Jia Hongtao-B38951 wrote: >>> I am really not sure that all boards need primary bus. Could you give >>> me the

Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-08 Thread Scott Wood
ao-B38951 wrote: >>>>> >>>>> >>>>>> -Original Message- >>>>>> From: Wood Scott-B07421 >>>>>> Sent: Saturday, August 04, 2012 12:28 AM >>>>>> To: Jia Hongtao-B38951 >>>>>> Cc:

RE: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-08 Thread Jia Hongtao-B38951
> -Original Message- > From: Wood Scott-B07421 > Sent: Tuesday, August 07, 2012 11:29 PM > To: Jia Hongtao-B38951 > Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org; > ga...@kernel.crashing.org; Li Yang-R58472 > Subject: Re: [PATCH V5 3/3] powerpc/fs

RE: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-08 Thread Jia Hongtao-B38951
> -Original Message- > From: Wood Scott-B07421 > Sent: Tuesday, August 07, 2012 11:25 PM > To: Li Yang-R58472 > Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org; Li Yang-R58472; Jia > Hongtao-B38951 > Subject: Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie

Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-07 Thread Scott Wood
On 08/07/2012 03:09 AM, Jia Hongtao-B38951 wrote: > I am really not sure that all boards need primary bus. Could you give me > the link of discussion about primary that you mentioned? https://lists.ozlabs.org/pipermail/linuxppc-dev/2012-June/098586.html -Scott __

Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-07 Thread Scott Wood
y, August 04, 2012 12:28 AM >>>> To: Jia Hongtao-B38951 >>>> Cc: linuxppc-dev@lists.ozlabs.org; ga...@kernel.crashing.org; Li Yang- >>>> R58472; Wood Scott-B07421 >>>> Subject: Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie >>>> ini

RE: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-07 Thread Jia Hongtao-B38951
c: linuxppc-dev@lists.ozlabs.org; ga...@kernel.crashing.org; Li > >> Yang- R58472; Wood Scott-B07421 > >> Subject: Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie > >> initialization code > >> > >> On 08/03/2012 05:14 AM, Jia Hongtao wrote: > &g

Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-06 Thread Li Yang
ao-B38951 >>> Cc: linuxppc-dev@lists.ozlabs.org; ga...@kernel.crashing.org; Li Yang- >>> R58472; Wood Scott-B07421 >>> Subject: Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie >>> initialization code >>> >>> On 08/03/2012 05:14 AM, Jia Hongtao wrot

Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-06 Thread Scott Wood
;> R58472; Wood Scott-B07421 >> Subject: Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie >> initialization code >> >> On 08/03/2012 05:14 AM, Jia Hongtao wrote: >>> -void __devinit fsl_pci_init(void) >>> +/* Checkout if PCI contains ISA node *

RE: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-05 Thread Jia Hongtao-B38951
> -Original Message- > From: Wood Scott-B07421 > Sent: Saturday, August 04, 2012 12:28 AM > To: Jia Hongtao-B38951 > Cc: linuxppc-dev@lists.ozlabs.org; ga...@kernel.crashing.org; Li Yang- > R58472; Wood Scott-B07421 > Subject: Re: [PATCH V5 3/3] powerpc/fs

Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-03 Thread Scott Wood
On 08/03/2012 05:14 AM, Jia Hongtao wrote: > -void __devinit fsl_pci_init(void) > +/* Checkout if PCI contains ISA node */ > +static int of_pci_has_isa(struct device_node *pci_node) > +{ > + struct device_node *np; > + int ret = 0; > + > + if (!pci_node) > + return 0; > + >

[PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-03 Thread Jia Hongtao
We unified the Freescale pci/pcie initialization by changing the fsl_pci to a platform driver. In previous PCI code architecture the initialization routine is called at board_setup_arch stage. Now the initialization is done in probe function which is architectural better. Also It's convenient for a