Re: [PATCH V2 2/2] mtd/maps/mtd-ram: add an of-platform driver

2009-06-16 Thread Grant Likely
Okay, fair enough. I wasn't paying very close attention when I replied. It still seems awkward to me, but not enough to object (ie. It's not dangerous). g. On Jun 16, 2009 7:20 AM, "Wolfram Sang" wrote: > > Grant wondered if we need a bankwidth. IMHO it is needed for now, but I don't > > know

Re: [PATCH V2 2/2] mtd/maps/mtd-ram: add an of-platform driver

2009-06-16 Thread Albrecht Dreß
Am 16.06.09 14:53 schrieb(en) Grant Likely: I'm not happy about the use case though. It probably shouldn't appear in this binding, or if it does it should be tagged as an optional property. I agree with you that the naming is really misleading - other devices which are not mtd's may suffe

Re: [PATCH V2 2/2] mtd/maps/mtd-ram: add an of-platform driver

2009-06-16 Thread Wolfram Sang
> > Grant wondered if we need a bankwidth. IMHO it is needed for now, but I > > don't > > know if this is a common agreement. > > I'm not happy about the use case though. It probably shouldn't appear > in this binding, or if it does it should be tagged as an optional > property. It is only in t

Re: [PATCH V2 2/2] mtd/maps/mtd-ram: add an of-platform driver

2009-06-16 Thread Grant Likely
On Tue, Jun 16, 2009 at 3:18 AM, Wolfram Sang wrote: > On Mon, Jun 15, 2009 at 07:43:20PM +0200, Albrecht Dreß wrote: >> Am 05.06.09 14:05 schrieb(en) Wolfram Sang: >>> Create an of-aware driver using the now exported generic functions >>> from plat-ram.c. Also add the documentation for the binding

Re: [PATCH V2 2/2] mtd/maps/mtd-ram: add an of-platform driver

2009-06-16 Thread Wolfram Sang
On Mon, Jun 15, 2009 at 07:43:20PM +0200, Albrecht Dreß wrote: > Am 05.06.09 14:05 schrieb(en) Wolfram Sang: >> Create an of-aware driver using the now exported generic functions >> from plat-ram.c. Also add the documentation for the binding. >> Partitions are not yet supported. Tested on a phy

Re: [PATCH V2 2/2] mtd/maps/mtd-ram: add an of-platform driver

2009-06-16 Thread Wolfram Sang
On Sat, Jun 06, 2009 at 09:14:08AM +0100, David Woodhouse wrote: > On Fri, 2009-06-05 at 14:05 +0200, Wolfram Sang wrote: > > Create an of-aware driver using the now exported generic functions from > > plat-ram.c. Also add the documentation for the binding. Partitions are > > not yet supported. Tes

Re: [PATCH V2 2/2] mtd/maps/mtd-ram: add an of-platform driver

2009-06-15 Thread Albrecht Dreß
Am 05.06.09 14:05 schrieb(en) Wolfram Sang: Create an of-aware driver using the now exported generic functions from plat-ram.c. Also add the documentation for the binding. Partitions are not yet supported. Tested on a phyCORE-MPC5200B-IO. Dumb question: what is the current status of this pat

Re: [PATCH V2 2/2] mtd/maps/mtd-ram: add an of-platform driver

2009-06-08 Thread Albrecht Dreß
Am 08.06.09 18:35 schrieb(en) Wolfram Sang: Question: why is bank-width even relevant for a RAM device? The underlying map_ram-driver uses it once while erasing. The question remains if this is really needed? Am 06.06.09 18:16 schrieb(en) Albrecht Dreß: At least if the RAM is attached to th

Re: [PATCH V2 2/2] mtd/maps/mtd-ram: add an of-platform driver

2009-06-08 Thread Wolfram Sang
> Question: why is bank-width even relevant for a RAM device? The underlying map_ram-driver uses it once while erasing. The question remains if this is really needed? And: Does this need to get solved before merging my patches because changing the binding afterwards is hard? Or can they go mainlin

Re: [PATCH V2 2/2] mtd/maps/mtd-ram: add an of-platform driver

2009-06-06 Thread Albrecht Dreß
Am 06.06.09 18:05 schrieb(en) Grant Likely: > + - bank-width : Width (in bytes) of the RAM bank. Question: why is bank-width even relevant for a RAM device? At least if the RAM is attached to the 5200's Local Plus Bus in 16-bit mode, no byte write accesses are allowed (byte /reads/ work, tho

Re: [PATCH V2 2/2] mtd/maps/mtd-ram: add an of-platform driver

2009-06-06 Thread Grant Likely
On Fri, Jun 5, 2009 at 6:05 AM, Wolfram Sang wrote: > diff --git a/Documentation/powerpc/dts-bindings/mtd-ram.txt > b/Documentation/powerpc/dts-bindings/mtd-ram.txt > new file mode 100644 > index 000..a2e9932 > --- /dev/null > +++ b/Documentation/powerpc/dts-bindings/mtd-ram.txt > @@ -0,0 +1,1

Re: [PATCH V2 2/2] mtd/maps/mtd-ram: add an of-platform driver

2009-06-06 Thread Wolfram Sang
On Sat, Jun 06, 2009 at 09:14:08AM +0100, David Woodhouse wrote: > On Fri, 2009-06-05 at 14:05 +0200, Wolfram Sang wrote: > > Create an of-aware driver using the now exported generic functions from > > plat-ram.c. Also add the documentation for the binding. Partitions are > > not yet supported. Te

Re: [PATCH V2 2/2] mtd/maps/mtd-ram: add an of-platform driver

2009-06-06 Thread David Woodhouse
On Fri, 2009-06-05 at 14:05 +0200, Wolfram Sang wrote: > Create an of-aware driver using the now exported generic functions from > plat-ram.c. Also add the documentation for the binding. Partitions are > not yet supported. Tested on a phyCORE-MPC5200B-IO. Do we have an ack for the device-tree bind

Re: [PATCH V2 2/2] mtd/maps/mtd-ram: add an of-platform driver

2009-06-05 Thread Albrecht Dreß
Am 05.06.09 14:05 schrieb(en) Wolfram Sang: Create an of-aware driver using the now exported generic functions from plat-ram.c. Also add the documentation for the binding. Partitions are not yet supported. Tested on a phyCORE-MPC5200B-IO. Signed-off-by: Wolfram Sang Cc: Albrecht Dreß Cc: G

Re: [PATCH V2 2/2] mtd/maps/mtd-ram: add an of-platform driver

2009-06-05 Thread Grant Likely
On Fri, Jun 5, 2009 at 6:05 AM, Wolfram Sang wrote: > Create an of-aware driver using the now exported generic functions from > plat-ram.c. Also add the documentation for the binding. Partitions are > not yet supported. Tested on a phyCORE-MPC5200B-IO. > > Signed-off-by: Wolfram Sang > Cc: Albrec

[PATCH V2 2/2] mtd/maps/mtd-ram: add an of-platform driver

2009-06-05 Thread Wolfram Sang
Create an of-aware driver using the now exported generic functions from plat-ram.c. Also add the documentation for the binding. Partitions are not yet supported. Tested on a phyCORE-MPC5200B-IO. Signed-off-by: Wolfram Sang Cc: Albrecht Dreß Cc: Grant Likely Cc: Ben Dooks Cc: David Woodhouse C