Re: [PATCH 4/7] fs_enet: mac-fcc: Eliminate __fcc-* macros.

2007-08-22 Thread Scott Wood
Vitaly Bordug wrote: >>-#define W8(_p, _m, _v) __fcc_out8(&(_p)->_m, (_v)) >>-#define R8(_p, _m) __fcc_in8(&(_p)->_m) >>+#define W8(_p, _m, _v) out_8(&(_p)->_m, (_v)) >>+#define R8(_p, _m) in_8(&(_p)->_m) >> #define S8(_p, _m, _v) W8(_p, _m, R8(_p, _m) | (_v)) >> #define C8(_p

Re: [PATCH 4/7] fs_enet: mac-fcc: Eliminate __fcc-* macros.

2007-08-22 Thread Vitaly Bordug
On Fri, 17 Aug 2007 12:54:02 -0500 Scott Wood wrote: > These macros accomplish nothing other than defeating type checking. > > This patch also fixes one instance of the wrong register size being > used that was revealed by enabling type checking. > > Signed-off-by: Scott Wood <[EMAIL PROTECTED]>

[PATCH 4/7] fs_enet: mac-fcc: Eliminate __fcc-* macros.

2007-08-17 Thread Scott Wood
These macros accomplish nothing other than defeating type checking. This patch also fixes one instance of the wrong register size being used that was revealed by enabling type checking. Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- drivers/net/fs_enet/mac-fcc.c | 25 ---