Re: [PATCH 30/37] powerpc: mpc62xx_pic: fix get_irq handling of NO_IRQ

2011-05-11 Thread Grant Likely
On Wed, May 11, 2011 at 7:30 AM, Milton Miller wrote: > If none of irq category bits were set mpc52xx_get_irq() would pass > NO_IRQ_IGNORE (-1) to irq_linear_revmap, which does an unsigned compare > and declares the interrupt above the linear map range.  It then punts > to irq_find_mapping, which

[PATCH 30/37] powerpc: mpc62xx_pic: fix get_irq handling of NO_IRQ

2011-05-11 Thread Milton Miller
If none of irq category bits were set mpc52xx_get_irq() would pass NO_IRQ_IGNORE (-1) to irq_linear_revmap, which does an unsigned compare and declares the interrupt above the linear map range. It then punts to irq_find_mapping, which performs a linear search of all irqs, which will likely miss an