Re: [PATCH 2/6] powerpc/85xx: consolidate of_platform_bus_probe calls

2011-11-29 Thread Timur Tabi
Kumar Gala wrote: >> > The only fix I can think of is to move "fsl,eloplus-dma" into >> > mpc85xx_common_ids[]. I'll post a patch that does that, and we can >> > discuss it. > what if you make the p1022_ds_ids call first? Maybe we need to add 'soc' to > p1022_ds_ids list Reversing the calls

Re: [PATCH 2/6] powerpc/85xx: consolidate of_platform_bus_probe calls

2011-11-29 Thread Kumar Gala
On Nov 29, 2011, at 12:52 PM, Timur Tabi wrote: > Kumar Gala wrote: >> Ben would probably have to answer that. I can't remember why he wanted it. >> I'm sure he has a good reason. > > Well, I'm not sure what's going on with the code. I *think* what's happening > is that the first call of_pl

Re: [PATCH 2/6] powerpc/85xx: consolidate of_platform_bus_probe calls

2011-11-29 Thread Scott Wood
On 11/29/2011 10:20 AM, Timur Tabi wrote: > Timur Tabi wrote: > >> If I move the "fsl,eloplus-dma" into mpc85xx_common_ids[], then everything >> works. >> >> I suspect there's some kind of state machine in of_platform_bus_probe() that >> allows it to find the DMA channel nodes if it's scanned ev

Re: [PATCH 2/6] powerpc/85xx: consolidate of_platform_bus_probe calls

2011-11-29 Thread Timur Tabi
Kumar Gala wrote: > Ben would probably have to answer that. I can't remember why he wanted it. > I'm sure he has a good reason. Well, I'm not sure what's going on with the code. I *think* what's happening is that the first call of_platform_bus_probe() is scanning most, but not all, of the tr

Re: [PATCH 2/6] powerpc/85xx: consolidate of_platform_bus_probe calls

2011-11-29 Thread Kumar Gala
On Nov 29, 2011, at 10:20 AM, Timur Tabi wrote: > Timur Tabi wrote: > >> If I move the "fsl,eloplus-dma" into mpc85xx_common_ids[], then everything >> works. >> >> I suspect there's some kind of state machine in of_platform_bus_probe() that >> allows it to find the DMA channel nodes if it's s

Re: [PATCH 2/6] powerpc/85xx: consolidate of_platform_bus_probe calls

2011-11-29 Thread Timur Tabi
Timur Tabi wrote: > If I move the "fsl,eloplus-dma" into mpc85xx_common_ids[], then everything > works. > > I suspect there's some kind of state machine in of_platform_bus_probe() that > allows it to find the DMA channel nodes if it's scanned everything else > first. I'm trying to debug it no

Re: [PATCH 2/6] powerpc/85xx: consolidate of_platform_bus_probe calls

2011-11-29 Thread Timur Tabi
Kumar Gala wrote: >> I don't think this is working. I need to investigate some more to be >> sure, but it looks like this is not picking up "fsl,eloplus-dma". >> None of the DMA channels are being probed in the audio driver >> (sound/soc/fsl_dma.c). > > Hmm, that's odd. Should see if the issues

Re: [PATCH 2/6] powerpc/85xx: consolidate of_platform_bus_probe calls

2011-11-29 Thread Kumar Gala
On Nov 28, 2011, at 5:42 PM, Tabi Timur-B04825 wrote: > On Thu, Nov 17, 2011 at 11:56 AM, Dmitry Eremin-Solenikov > wrote: > >> diff --git a/arch/powerpc/platforms/85xx/p1022_ds.c >> b/arch/powerpc/platforms/85xx/p1022_ds.c >> index 00d93a4..cacb4d4 100644 >> --- a/arch/powerpc/platforms/85xx/

Re: [PATCH 2/6] powerpc/85xx: consolidate of_platform_bus_probe calls

2011-11-28 Thread Tabi Timur-B04825
On Thu, Nov 17, 2011 at 11:56 AM, Dmitry Eremin-Solenikov wrote: > diff --git a/arch/powerpc/platforms/85xx/p1022_ds.c > b/arch/powerpc/platforms/85xx/p1022_ds.c > index 00d93a4..cacb4d4 100644 > --- a/arch/powerpc/platforms/85xx/p1022_ds.c > +++ b/arch/powerpc/platforms/85xx/p1022_ds.c > @@ -33

Re: [PATCH 2/6] powerpc/85xx: consolidate of_platform_bus_probe calls

2011-11-23 Thread Kumar Gala
On Nov 17, 2011, at 11:56 AM, Dmitry Eremin-Solenikov wrote: > 85xx board files have a lot of duplication in *_publish_devices()/ > *_declare_of_platform_devices() functions. Merge that into a single > function common to most of the boards. > > Signed-off-by: Dmitry Eremin-Solenikov > --- > arc

[PATCH 2/6] powerpc/85xx: consolidate of_platform_bus_probe calls

2011-11-17 Thread Dmitry Eremin-Solenikov
85xx board files have a lot of duplication in *_publish_devices()/ *_declare_of_platform_devices() functions. Merge that into a single function common to most of the boards. Signed-off-by: Dmitry Eremin-Solenikov --- arch/powerpc/platforms/85xx/ksi8560.c| 17 +- arch/powerpc/pl