Re: [PATCH 2/3] rfi-flush: Make it possible to call setup_rfi_flush() again

2018-03-16 Thread Mauricio Faria de Oliveira
Michael, On 03/16/2018 11:18 AM, Michael Ellerman wrote: I still think the correct, informative messages are a good way to go:) Yeah I agree. We probably want to do both, print what's available at boot, and print what's actually patched when the patching happens. Nice. Not sure you had a ch

Re: [PATCH 2/3] rfi-flush: Make it possible to call setup_rfi_flush() again

2018-03-16 Thread Michael Ellerman
Mauricio Faria de Oliveira writes: > On 03/13/2018 03:36 PM, Michal Suchánek wrote: >> On Tue, 13 Mar 2018 15:13:11 -0300 >> Mauricio Faria de Oliveira wrote: >> >>> On 03/13/2018 02:59 PM, Michal Suchánek wrote: Maybe it would make more sense to move the messages to the function that

Re: [PATCH 2/3] rfi-flush: Make it possible to call setup_rfi_flush() again

2018-03-13 Thread Mauricio Faria de Oliveira
On 03/13/2018 03:36 PM, Michal Suchánek wrote: On Tue, 13 Mar 2018 15:13:11 -0300 Mauricio Faria de Oliveira wrote: On 03/13/2018 02:59 PM, Michal Suchánek wrote: Maybe it would make more sense to move the messages to the function that actually patches in the instructions? That helps, but

Re: [PATCH 2/3] rfi-flush: Make it possible to call setup_rfi_flush() again

2018-03-13 Thread Michal Suchánek
On Tue, 13 Mar 2018 15:13:11 -0300 Mauricio Faria de Oliveira wrote: > On 03/13/2018 02:59 PM, Michal Suchánek wrote: > > Maybe it would make more sense to move the messages to the function > > that actually patches in the instructions? > > That helps, but if the instructions are not patched (

Re: [PATCH 2/3] rfi-flush: Make it possible to call setup_rfi_flush() again

2018-03-13 Thread Mauricio Faria de Oliveira
On 03/13/2018 02:59 PM, Michal Suchánek wrote: Maybe it would make more sense to move the messages to the function that actually patches in the instructions? That helps, but if the instructions are not patched (e.g., no_rfi_flush) then there is no information about what the system actually supp

Re: [PATCH 2/3] rfi-flush: Make it possible to call setup_rfi_flush() again

2018-03-13 Thread Michal Suchánek
On Tue, 13 Mar 2018 09:14:39 -0300 Mauricio Faria de Oliveira wrote: > Hi Michael, > > On 03/13/2018 08:39 AM, Michael Ellerman wrote: > >> I agree; the 'Using fallback displacement flush' message is > >> misleading (is the system slower/fallback or not? Ô_o) > > > That message is actually ju

Re: [PATCH 2/3] rfi-flush: Make it possible to call setup_rfi_flush() again

2018-03-13 Thread Mauricio Faria de Oliveira
Hi Michael, On 03/13/2018 08:39 AM, Michael Ellerman wrote: I agree; the 'Using fallback displacement flush' message is misleading (is the system slower/fallback or not? Ô_o) That message is actually just wrong. It still prints that even if enable=false. So we should change all those messag

Re: [PATCH 2/3] rfi-flush: Make it possible to call setup_rfi_flush() again

2018-03-13 Thread Michael Ellerman
Mauricio Faria de Oliveira writes: > Hi Michael and Michal, > > Got back to this; sorry for the delay. > > On 03/06/2018 09:55 AM, Michal Suchánek wrote: >> Michael Ellerman wrote: > >>> I*think* the patch below is all we need, as well as some tweaking of >>> patch 2, are you able to test and r

Re: [PATCH 2/3] rfi-flush: Make it possible to call setup_rfi_flush() again

2018-03-12 Thread Mauricio Faria de Oliveira
Hi Michael and Michal, Got back to this; sorry for the delay. On 03/06/2018 09:55 AM, Michal Suchánek wrote: Michael Ellerman wrote: I*think* the patch below is all we need, as well as some tweaking of patch 2, are you able to test and repost? Enabling the fallback flush always looks a

Re: [PATCH 2/3] rfi-flush: Make it possible to call setup_rfi_flush() again

2018-03-06 Thread Michal Suchánek
On Tue, 06 Mar 2018 23:15:45 +1100 Michael Ellerman wrote: > Mauricio Faria de Oliveira writes: > > > Hi Michael, Michal, > > > > I got back from vacation. Checking this one. > > Yeah it got stuck in a rut. > > > On 02/20/2018 02:06 PM, Michal Suchánek wrote: > >>> I did it the way I did

Re: [PATCH 2/3] rfi-flush: Make it possible to call setup_rfi_flush() again

2018-03-06 Thread Michael Ellerman
Mauricio Faria de Oliveira writes: > Hi Michael, Michal, > > I got back from vacation. Checking this one. Yeah it got stuck in a rut. > On 02/20/2018 02:06 PM, Michal Suchánek wrote: >>> I did it the way I did because otherwise we waste memory on every >>> system on earth just to support a use

Re: [PATCH 2/3] rfi-flush: Make it possible to call setup_rfi_flush() again

2018-03-06 Thread Michal Suchánek
On Mon, 5 Mar 2018 19:46:12 -0300 Mauricio Faria de Oliveira wrote: > Hi Michael, Michal, > > I got back from vacation. Checking this one. > > On 02/20/2018 02:06 PM, Michal Suchánek wrote: > >> I did it the way I did because otherwise we waste memory on every > >> system on earth just to suppo

Re: [PATCH 2/3] rfi-flush: Make it possible to call setup_rfi_flush() again

2018-03-05 Thread Mauricio Faria de Oliveira
Hi Michael, Michal, I got back from vacation. Checking this one. On 02/20/2018 02:06 PM, Michal Suchánek wrote: I did it the way I did because otherwise we waste memory on every system on earth just to support a use case that we don't actually intend for anyone to ever use - ie. migrating from

Re: [PATCH 2/3] rfi-flush: Make it possible to call setup_rfi_flush() again

2018-02-20 Thread Michal Suchánek
On Tue, 20 Feb 2018 20:59:18 +1100 Michael Ellerman wrote: > Mauricio Faria de Oliveira writes: > > > Hi Michal and Michael, > > > > On 02/15/2018 05:13 AM, Michal Suchánek wrote: > >>> From: Michael Ellerman > >>> > >>> For PowerVM migration we want to be able to call setup_rfi_flush() > >>>

Re: [PATCH 2/3] rfi-flush: Make it possible to call setup_rfi_flush() again

2018-02-20 Thread Michael Ellerman
Mauricio Faria de Oliveira writes: > Hi Michal and Michael, > > On 02/15/2018 05:13 AM, Michal Suchánek wrote: >>> From: Michael Ellerman >>> >>> For PowerVM migration we want to be able to call setup_rfi_flush() >>> again after we've migrated the partition. >>> >>> To support that we need to che

Re: [PATCH 2/3] rfi-flush: Make it possible to call setup_rfi_flush() again

2018-02-16 Thread Mauricio Faria de Oliveira
Hi Michal and Michael, On 02/15/2018 05:13 AM, Michal Suchánek wrote: From: Michael Ellerman For PowerVM migration we want to be able to call setup_rfi_flush() again after we've migrated the partition. To support that we need to check that we're not trying to allocate the fallback flush area a

Re: [PATCH 2/3] rfi-flush: Make it possible to call setup_rfi_flush() again

2018-02-14 Thread Michal Suchánek
Hello, On Wed, 14 Feb 2018 19:33:40 -0200 Mauricio Faria de Oliveira wrote: > From: Michael Ellerman > > For PowerVM migration we want to be able to call setup_rfi_flush() > again after we've migrated the partition. > > To support that we need to check that we're not trying to allocate the >

[PATCH 2/3] rfi-flush: Make it possible to call setup_rfi_flush() again

2018-02-14 Thread Mauricio Faria de Oliveira
From: Michael Ellerman For PowerVM migration we want to be able to call setup_rfi_flush() again after we've migrated the partition. To support that we need to check that we're not trying to allocate the fallback flush area after memblock has gone away. If so we just fail, we don't support migrat