Re: [PATCH 2/2 v4] MPC52xx FEC: be more conservative when setting MII_SPEED register

2009-07-17 Thread Grant Likely
On Fri, Jul 17, 2009 at 11:51 AM, Wolfgang Denk wrote: > Dear Grant Likely, > > In message you > wrote: >> >> >  drivers/net/fec_mpc52xx.c     |   25 ++--- >> >  drivers/net/fec_mpc52xx_phy.c |   23 --- >> >> Blech.  now this block of duplicated code I don'

Re: [PATCH 2/2 v4] MPC52xx FEC: be more conservative when setting MII_SPEED register

2009-07-17 Thread Wolfgang Denk
Dear Grant Likely, In message you wrote: > > > drivers/net/fec_mpc52xx.c | 25 ++--- > > drivers/net/fec_mpc52xx_phy.c | 23 --- > > Blech. now this block of duplicated code I don't like. This is all > one device, so surely the mdio speed can be

Re: [PATCH 2/2 v4] MPC52xx FEC: be more conservative when setting MII_SPEED register

2009-07-17 Thread Grant Likely
On Fri, Jul 17, 2009 at 6:59 AM, Wolfgang Denk wrote: > This patch adds error checking and prevents clobbering unrelated bits > (reserved bits or the DIS_PREAMBLE bit) when writing the MII_SPEED > register on MPC52xx systems. > > Signed-off-by: Wolfgang Denk > Cc: Grant Likely > Cc: Kumar Gala >

[PATCH 2/2 v4] MPC52xx FEC: be more conservative when setting MII_SPEED register

2009-07-17 Thread Wolfgang Denk
This patch adds error checking and prevents clobbering unrelated bits (reserved bits or the DIS_PREAMBLE bit) when writing the MII_SPEED register on MPC52xx systems. Signed-off-by: Wolfgang Denk Cc: Grant Likely Cc: Kumar Gala Cc: --- v3: - use maximum divider in case MPC512x IPS clock is unkn