On Fri, Jul 17, 2009 at 11:51 AM, Wolfgang Denk<w...@denx.de> wrote: > Dear Grant Likely, > > In message <fa686aa40907170745h6c5fae6bia0cff0926c933...@mail.gmail.com> you > wrote: >> >> > drivers/net/fec_mpc52xx.c | 25 ++++++++++++++++++++++--- >> > drivers/net/fec_mpc52xx_phy.c | 23 ++++++++++++++++++++--- >> >> Blech. now this block of duplicated code I don't like. This is all >> one device, so surely the mdio speed can be calculated once and used >> for both drivers.... let me think about this for a bit. 'course this >> problem is all rolled up in the nastiness of having two drivers >> working on the same device. I suspect is was a mistake to split up >> all the powerpc ethernet drivers into separate of_platform drivers. > > If you like, I can re-introduce the mpc5xxx_get_mii_speed() I unrolled > upon your request (with or without re-using it for the MPC512x case).
No, there's a deeper issues here. I'm bothered that the mac driver is impacting the mdio driver. I'd like to find a way for this whole thing to be handled cleaner, and not have two different drivers calculate it. g. > > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de > What is mind? No matter. What is matter? Never mind. > -- Thomas Hewitt Key, 1799-1875 > -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
