Re: [PATCH 2/2] leds: Support OpenFirmware led bindings

2008-07-28 Thread Trent Piepho
On Mon, 28 Jul 2008, Anton Vorontsov wrote: > On Mon, Jul 28, 2008 at 11:26:28AM -0700, Trent Piepho wrote: >> On Mon, 28 Jul 2008, Anton Vorontsov wrote: >>> On Mon, Jul 28, 2008 at 11:09:14AM -0600, Grant Likely wrote: >>> [...] >>> +- function : (optional) This parameter, if present, is a s

Re: [PATCH 2/2] leds: Support OpenFirmware led bindings

2008-07-28 Thread Anton Vorontsov
On Mon, Jul 28, 2008 at 11:26:28AM -0700, Trent Piepho wrote: > On Mon, 28 Jul 2008, Anton Vorontsov wrote: > > On Mon, Jul 28, 2008 at 11:09:14AM -0600, Grant Likely wrote: > > [...] > > +- function : (optional) This parameter, if present, is a string > > + defining the function of the L

Re: [PATCH 2/2] leds: Support OpenFirmware led bindings

2008-07-28 Thread Grant Likely
On Mon, Jul 28, 2008 at 11:26:28AM -0700, Trent Piepho wrote: > On Mon, 28 Jul 2008, Anton Vorontsov wrote: > > On Mon, Jul 28, 2008 at 11:09:14AM -0600, Grant Likely wrote: > > [...] > > +- function : (optional) This parameter, if present, is a string > > + defining the function of the L

Re: [PATCH 2/2] leds: Support OpenFirmware led bindings

2008-07-28 Thread Trent Piepho
On Mon, 28 Jul 2008, Anton Vorontsov wrote: > On Mon, Jul 28, 2008 at 11:09:14AM -0600, Grant Likely wrote: > [...] > +- function : (optional) This parameter, if present, is a string > + defining the function of the LED. It can be used to put the LED > + under software control, e.g.

Re: [PATCH 2/2] leds: Support OpenFirmware led bindings

2008-07-28 Thread Grant Likely
On Mon, Jul 28, 2008 at 10:02:04PM +0400, Anton Vorontsov wrote: > On Mon, Jul 28, 2008 at 11:09:14AM -0600, Grant Likely wrote: > > I'd rather see the device tree provide 'hints' toward the expected usage > > and if a platform needs something specific, then the platform specific > > code should se

Re: [PATCH 2/2] leds: Support OpenFirmware led bindings

2008-07-28 Thread Anton Vorontsov
On Mon, Jul 28, 2008 at 11:09:14AM -0600, Grant Likely wrote: [...] > > >> +- function : (optional) This parameter, if present, is a string > > >> + defining the function of the LED. It can be used to put the LED > > >> + under software control, e.g. Linux LED triggers like "heartbeat", > > >>

Re: [PATCH 2/2] leds: Support OpenFirmware led bindings

2008-07-28 Thread Grant Likely
On Mon, Jul 28, 2008 at 01:31:47AM -0700, Trent Piepho wrote: > On Sat, 26 Jul 2008, Grant Likely wrote: > > On Fri, Jul 25, 2008 at 02:01:45PM -0700, Trent Piepho wrote: > >> Add bindings to support LEDs defined as of_platform devices in addition to > >> the existing bindings for platform devices.

Re: [PATCH 2/2] leds: Support OpenFirmware led bindings

2008-07-28 Thread Trent Piepho
On Sat, 26 Jul 2008, Grant Likely wrote: > On Fri, Jul 25, 2008 at 02:01:45PM -0700, Trent Piepho wrote: >> Add bindings to support LEDs defined as of_platform devices in addition to >> the existing bindings for platform devices. > >> +- gpios : Should specify the LED GPIO. > > Question: it is pos

Re: [PATCH 2/2] leds: Support OpenFirmware led bindings

2008-07-26 Thread Grant Likely
On Fri, Jul 25, 2008 at 02:01:45PM -0700, Trent Piepho wrote: > Add bindings to support LEDs defined as of_platform devices in addition to > the existing bindings for platform devices. (adding [EMAIL PROTECTED] to the cc list) > New options in Kconfig allow the platform binding code and/or the >

[PATCH 2/2] leds: Support OpenFirmware led bindings

2008-07-25 Thread Trent Piepho
Add bindings to support LEDs defined as of_platform devices in addition to the existing bindings for platform devices. New options in Kconfig allow the platform binding code and/or the of_platform code to be turned on. The of_platform code is of course only available on archs that have OF support