Re: [PATCH 2/2] Add local bus device nodes to MPC837xMDS device trees.

2008-03-11 Thread Segher Boessenkool
This isn't a problem with this device tree, but it's probably time we started establishing some conventional generic names for nand flash and board-control devices. So, to start the ball rolling, I've seen several names for nand flash nodes, I'd suggest we standardise on "nand-flash". What's wr

Re: [PATCH 2/2] Add local bus device nodes to MPC837xMDS device trees.

2008-03-10 Thread David Gibson
On Tue, Mar 11, 2008 at 01:43:49AM +0100, Arnd Bergmann wrote: > On Tuesday 11 March 2008, David Gibson wrote: > > On Fri, Mar 07, 2008 at 04:39:30AM +0100, Segher Boessenkool wrote: > > > > This isn't a problem with this device tree, but it's probably time we > > > > started establishing some conv

Re: [PATCH 2/2] Add local bus device nodes to MPC837xMDS device trees.

2008-03-10 Thread Arnd Bergmann
On Tuesday 11 March 2008, David Gibson wrote: > On Fri, Mar 07, 2008 at 04:39:30AM +0100, Segher Boessenkool wrote: > > > This isn't a problem with this device tree, but it's probably time we > > > started establishing some conventional generic names for nand flash > > > and board-control devices.

Re: [PATCH 2/2] Add local bus device nodes to MPC837xMDS device trees.

2008-03-10 Thread David Gibson
On Fri, Mar 07, 2008 at 04:39:30AM +0100, Segher Boessenkool wrote: > > This isn't a problem with this device tree, but it's probably time we > > started establishing some conventional generic names for nand flash > > and board-control devices. > > > > So, to start the ball rolling, I've seen sever

Re: [PATCH 2/2] Add local bus device nodes to MPC837xMDS device trees.

2008-03-07 Thread David Gibson
On Fri, Mar 07, 2008 at 08:35:39AM -0600, Kumar Gala wrote: > On Mar 6, 2008, at 6:27 PM, David Gibson wrote: [snip] > > I've seen several variants for board control devices (cpld, bcsr, > > fpga, etc.) I suggest we standardise on "board-control" > > I don't see any reason for this. If I have a c

Re: [PATCH 2/2] Add local bus device nodes to MPC837xMDS device trees.

2008-03-07 Thread Segher Boessenkool
>> I've seen several variants for board control devices (cpld, bcsr, >> fpga, etc.) I suggest we standardise on "board-control" > > I don't see any reason for this. If I have a cpld or fpga why not > just call it that. I don't see what calling it 'board-control' gets > us. There may be non-board

Re: [PATCH 2/2] Add local bus device nodes to MPC837xMDS device trees.

2008-03-07 Thread Kumar Gala
On Mar 6, 2008, at 4:42 AM, Li Yang wrote: > Signed-off-by: Li Yang <[EMAIL PROTECTED]> > --- > arch/powerpc/boot/dts/mpc8377_mds.dts | 66 > + > arch/powerpc/boot/dts/mpc8378_mds.dts | 66 > + > arch/powerpc/boot/dts/mpc8379_m

Re: [PATCH 2/2] Add local bus device nodes to MPC837xMDS device trees.

2008-03-07 Thread Kumar Gala
On Mar 6, 2008, at 6:27 PM, David Gibson wrote: > [snip] >> +[EMAIL PROTECTED],0 { >> +reg = <1 0x0 0x8000>; >> +compatible = "fsl,mpc837xmds-bcsr"; >> +}; >> + >> +[EMAIL PROTECTED],0 { > > This isn't a problem with this

Re: [PATCH 2/2] Add local bus device nodes to MPC837xMDS device trees.

2008-03-06 Thread Segher Boessenkool
> This isn't a problem with this device tree, but it's probably time we > started establishing some conventional generic names for nand flash > and board-control devices. > > So, to start the ball rolling, I've seen several names for nand flash > nodes, I'd suggest we standardise on "nand-flash".

Re: [PATCH 2/2] Add local bus device nodes to MPC837xMDS device trees.

2008-03-06 Thread David Gibson
[snip] > + [EMAIL PROTECTED],0 { > + reg = <1 0x0 0x8000>; > + compatible = "fsl,mpc837xmds-bcsr"; > + }; > + > + [EMAIL PROTECTED],0 { This isn't a problem with this device tree, but it's probably time we started establis

[PATCH 2/2] Add local bus device nodes to MPC837xMDS device trees.

2008-03-06 Thread Li Yang
Signed-off-by: Li Yang <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/mpc8377_mds.dts | 66 + arch/powerpc/boot/dts/mpc8378_mds.dts | 66 + arch/powerpc/boot/dts/mpc8379_mds.dts | 66 + arch/powerp