Re: [PATCH 2/11] cell: generalize io-workarounds code

2008-04-23 Thread Benjamin Herrenschmidt
On Thu, 2008-04-24 at 12:07 +0900, Ishizaki Kou wrote: > > I'm sorry to have kept you waiting for my response. > > I just finished reviewing your patch. Your patch works well on > Celleb, and I found I also should do the same thing for Celleb as you > pointed. I will send a new patch which inc

Re: [PATCH 2/11] cell: generalize io-workarounds code

2008-04-23 Thread Ishizaki Kou
Ben-san, I'm sorry to have kept you waiting for my response. I just finished reviewing your patch. Your patch works well on Celleb, and I found I also should do the same thing for Celleb as you pointed. I will send a new patch which includes your fix. Benjamin Herrenschmidt <[EMAIL PROTECTED]

Re: [PATCH 2/11] cell: generalize io-workarounds code

2008-04-23 Thread Ishizaki Kou
Ben-san, I'm sorry to have kept you waiting for my response. I just finished reviewing your patch. Your patch works well on Celleb, and I found I also should do the same thing for Celleb as you pointed. I will send a new patch which includes your fix. Benjamin Herrenschmidt <[EMAIL PROTECTED]

Re: [PATCH 2/11] cell: generalize io-workarounds code

2008-04-16 Thread Benjamin Herrenschmidt
So I found a few issues with your patch. Below is a "Fixup" patch that fixes the QS20 cell blades for me, but I would like you to apply that directly to your series and post a new version of it so that there is no breakage of QS20 during bisection. Note that I believe Celleb may have some problems

Re: [PATCH 2/11] cell: generalize io-workarounds code

2008-04-16 Thread Benjamin Herrenschmidt
On Fri, 2008-03-14 at 21:20 +0900, Ishizaki Kou wrote: > This patch splits cell io-workaround code into spider-pci dependent > code and a generic part, and also adds interfaces to the generic > io-workaround mechanism. > > Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]> > --- > > Please test on

Re: [PATCH 2/11] cell: generalize io-workarounds code

2008-04-09 Thread Ishizaki Kou
Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > On Fri, 2008-04-04 at 15:42 +0900, Ishizaki Kou wrote: > > > > As you pointed, spider I/O functions in Cell blades need 2 step > > indirections by our patch. Shall I make another one for Cell blades > > whose spider I/O functions need one step in

Re: [PATCH 2/11] cell: generalize io-workarounds code

2008-04-04 Thread Benjamin Herrenschmidt
On Fri, 2008-04-04 at 15:42 +0900, Ishizaki Kou wrote: > > As you pointed, spider I/O functions in Cell blades need 2 step > indirections by our patch. Shall I make another one for Cell blades > whose spider I/O functions need one step indirection? > (But you will need 2 step indirections when yo

Re: [PATCH 2/11] cell: generalize io-workarounds code

2008-04-03 Thread Ishizaki Kou
Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > On Wed, 2008-04-02 at 19:52 +0900, Ishizaki Kou wrote: > > Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > > > As you said, if read/write/in/out functions take device parameter, > > > > taking I/O function pointers into the dev_archdata stru

Re: [PATCH 2/11] cell: generalize io-workarounds code

2008-04-02 Thread Benjamin Herrenschmidt
On Wed, 2008-04-02 at 19:52 +0900, Ishizaki Kou wrote: > Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > > As you said, if read/write/in/out functions take device parameter, > > > taking I/O function pointers into the dev_archdata structure should be > > > the best solution. But they don't t

Re: [PATCH 2/11] cell: generalize io-workarounds code

2008-04-02 Thread Ishizaki Kou
Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > As you said, if read/write/in/out functions take device parameter, > > taking I/O function pointers into the dev_archdata structure should be > > the best solution. But they don't take device parameter, and they must > > search I/O function poin

Re: [PATCH 2/11] cell: generalize io-workarounds code

2008-03-27 Thread Benjamin Herrenschmidt
On Thu, 2008-03-27 at 20:02 +0900, Ishizaki Kou wrote: > > > I'll try to have a closer look next week, but I'm a bit worried by > > having all IO go through 2 level of function pointers, the PPE isn't > > very good at it and this will slow things down more than they > already > > are. > > Only o

Re: [PATCH 2/11] cell: generalize io-workarounds code

2008-03-27 Thread Ishizaki Kou
Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > I may have missed something in your patch but if the workarounds are > specific to a given bridge, they may as well set the top level > indirections once straight to the right workarounds. > > Also, my understanding is that we are pretty much usi

Re: [PATCH 2/11] cell: generalize io-workarounds code

2008-03-24 Thread Benjamin Herrenschmidt
On Mon, 2008-03-24 at 21:41 +1100, Benjamin Herrenschmidt wrote: > On Fri, 2008-03-14 at 21:20 +0900, Ishizaki Kou wrote: > > This patch splits cell io-workaround code into spider-pci dependent > > code and a generic part, and also adds interfaces to the generic > > io-workaround mechanism. > > >

Re: [PATCH 2/11] cell: generalize io-workarounds code

2008-03-24 Thread Benjamin Herrenschmidt
On Fri, 2008-03-14 at 21:20 +0900, Ishizaki Kou wrote: > This patch splits cell io-workaround code into spider-pci dependent > code and a generic part, and also adds interfaces to the generic > io-workaround mechanism. > > Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]> > --- Hi ! I noticed tha

[PATCH 2/11] cell: generalize io-workarounds code

2008-03-14 Thread Ishizaki Kou
This patch splits cell io-workaround code into spider-pci dependent code and a generic part, and also adds interfaces to the generic io-workaround mechanism. Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]> --- Please test on CellBlade because I don't have any access to CellBlade. arch/powerpc/