[PATCH 11/17] Add memory mapping driver to RapidIO.

2008-03-11 Thread Zhang Wei
The memory mapping driver is used for mapping IO address and system memory address space to RapidIO address space. The driver support IO space allocation, RapidIO space inbound window and outbound window creation. The system can access other RapidIO device by outbound window and can be accessed by

RE: [PATCH 11/17] Add memory mapping driver to RapidIO.

2008-03-11 Thread Zhang Wei
: Re: [PATCH 11/17] Add memory mapping driver to RapidIO. > > Hi Weu, > > On Wed, 5 Mar 2008 09:59:38 +0800 "Zhang Wei" > <[EMAIL PROTECTED]> wrote: > > > > Thanks! I'm considering to commit a updated patch or new > code cleaning > > patch.

Re: [PATCH 11/17] Add memory mapping driver to RapidIO.

2008-03-04 Thread Stephen Rothwell
Hi Weu, On Wed, 5 Mar 2008 09:59:38 +0800 "Zhang Wei" <[EMAIL PROTECTED]> wrote: > > Thanks! I'm considering to commit a updated patch or new code cleaning > patch. > How about your idea? Preferably, fix up the patches. If that is a pain, then a followup patch that cleans up is ok as these do no

RE: [PATCH 11/17] Add memory mapping driver to RapidIO.

2008-03-04 Thread Zhang Wei
L PROTECTED]; [EMAIL PROTECTED]; > linuxppc-dev@ozlabs.org; [EMAIL PROTECTED] > Subject: Re: [PATCH 11/17] Add memory mapping driver to RapidIO. > > On Wed, 5 Mar 2008 00:29:56 +0800 Zhang Wei > <[EMAIL PROTECTED]> wrote: > > > > + i

Re: [PATCH 11/17] Add memory mapping driver to RapidIO.

2008-03-04 Thread Stephen Rothwell
On Wed, 5 Mar 2008 00:29:56 +0800 Zhang Wei <[EMAIL PROTECTED]> wrote: > > + if (!(rmem->virt = dma_alloc_coherent(NULL, rmem->size, > + &rmem->iores.start, GFP_KERNEL))) { Please separate assignments from tests. > + if ((ret = rio_space_claim(rmem))) { Again

[PATCH 11/17] Add memory mapping driver to RapidIO.

2008-03-04 Thread Zhang Wei
The memory mapping driver is used for mapping IO address and system memory address space to RapidIO address space. The driver support IO space allocation, RapidIO space inbound window and outbound window creation. The system can access other RapidIO device by outbound window and can be accessed by