Re: [PATCH 1/9] ARM: get rid of arch_cpu_idle_prepare()

2014-01-27 Thread Daniel Lezcano
On 01/27/2014 05:07 PM, Russell King - ARM Linux wrote: On Mon, Jan 27, 2014 at 09:22:55AM +0100, Daniel Lezcano wrote: On 01/27/2014 07:08 AM, Nicolas Pitre wrote: ARM and ARM64 are the only two architectures implementing arch_cpu_idle_prepare() simply to call local_fiq_enable(). We have seco

Re: [PATCH 1/9] ARM: get rid of arch_cpu_idle_prepare()

2014-01-27 Thread Peter Zijlstra
On Mon, Jan 27, 2014 at 05:21:10PM +, Russell King - ARM Linux wrote: > A reviewed-by tag on its own doesn't mean much, as it could mean that > you've just glanced over the code and decided "yea, it looks okay", or > it could mean that you've spent all day verifying that the code change > is in

Re: [PATCH 1/9] ARM: get rid of arch_cpu_idle_prepare()

2014-01-27 Thread Nicolas Pitre
On Mon, 27 Jan 2014, Russell King - ARM Linux wrote: > On Mon, Jan 27, 2014 at 10:45:59AM -0500, Nicolas Pitre wrote: > > On Mon, 27 Jan 2014, Russell King - ARM Linux wrote: > > > > > On Mon, Jan 27, 2014 at 01:08:16AM -0500, Nicolas Pitre wrote: > > > > ARM and ARM64 are the only two architectu

Re: [PATCH 1/9] ARM: get rid of arch_cpu_idle_prepare()

2014-01-27 Thread Daniel Lezcano
On 01/27/2014 06:21 PM, Russell King - ARM Linux wrote: On Mon, Jan 27, 2014 at 06:12:53PM +0100, Daniel Lezcano wrote: On 01/27/2014 05:07 PM, Russell King - ARM Linux wrote: On Mon, Jan 27, 2014 at 09:22:55AM +0100, Daniel Lezcano wrote: On 01/27/2014 07:08 AM, Nicolas Pitre wrote: ARM and

Re: [PATCH 1/9] ARM: get rid of arch_cpu_idle_prepare()

2014-01-27 Thread Russell King - ARM Linux
On Mon, Jan 27, 2014 at 06:12:53PM +0100, Daniel Lezcano wrote: > On 01/27/2014 05:07 PM, Russell King - ARM Linux wrote: >> On Mon, Jan 27, 2014 at 09:22:55AM +0100, Daniel Lezcano wrote: >>> On 01/27/2014 07:08 AM, Nicolas Pitre wrote: ARM and ARM64 are the only two architectures implementin

Re: [PATCH 1/9] ARM: get rid of arch_cpu_idle_prepare()

2014-01-27 Thread Russell King - ARM Linux
On Mon, Jan 27, 2014 at 09:22:55AM +0100, Daniel Lezcano wrote: > On 01/27/2014 07:08 AM, Nicolas Pitre wrote: >> ARM and ARM64 are the only two architectures implementing >> arch_cpu_idle_prepare() simply to call local_fiq_enable(). >> >> We have secondary_start_kernel() already calling local_fiq_

Re: [PATCH 1/9] ARM: get rid of arch_cpu_idle_prepare()

2014-01-27 Thread Russell King - ARM Linux
On Mon, Jan 27, 2014 at 10:45:59AM -0500, Nicolas Pitre wrote: > On Mon, 27 Jan 2014, Russell King - ARM Linux wrote: > > > On Mon, Jan 27, 2014 at 01:08:16AM -0500, Nicolas Pitre wrote: > > > ARM and ARM64 are the only two architectures implementing > > > arch_cpu_idle_prepare() simply to call lo

Re: [PATCH 1/9] ARM: get rid of arch_cpu_idle_prepare()

2014-01-27 Thread Nicolas Pitre
On Mon, 27 Jan 2014, Russell King - ARM Linux wrote: > On Mon, Jan 27, 2014 at 01:08:16AM -0500, Nicolas Pitre wrote: > > ARM and ARM64 are the only two architectures implementing > > arch_cpu_idle_prepare() simply to call local_fiq_enable(). > > > > We have secondary_start_kernel() already calli

Re: [PATCH 1/9] ARM: get rid of arch_cpu_idle_prepare()

2014-01-27 Thread Russell King - ARM Linux
On Mon, Jan 27, 2014 at 01:08:16AM -0500, Nicolas Pitre wrote: > ARM and ARM64 are the only two architectures implementing > arch_cpu_idle_prepare() simply to call local_fiq_enable(). > > We have secondary_start_kernel() already calling local_fiq_enable() and > this is done a second time in arch_c

Re: [PATCH 1/9] ARM: get rid of arch_cpu_idle_prepare()

2014-01-27 Thread Daniel Lezcano
On 01/27/2014 07:08 AM, Nicolas Pitre wrote: ARM and ARM64 are the only two architectures implementing arch_cpu_idle_prepare() simply to call local_fiq_enable(). We have secondary_start_kernel() already calling local_fiq_enable() and this is done a second time in arch_cpu_idle_prepare() in that

[PATCH 1/9] ARM: get rid of arch_cpu_idle_prepare()

2014-01-26 Thread Nicolas Pitre
ARM and ARM64 are the only two architectures implementing arch_cpu_idle_prepare() simply to call local_fiq_enable(). We have secondary_start_kernel() already calling local_fiq_enable() and this is done a second time in arch_cpu_idle_prepare() in that case. And enabling FIQs has nothing to do with