Re: [PATCH 1/4] Add helpers for finding a device node which as a certain property

2008-11-12 Thread David Miller
From: Michael Ellerman <[EMAIL PROTECTED]> Date: Thu, 13 Nov 2008 18:11:43 +1100 > With my compiler (4.3.1) it just gets inlined and actually makes the > text 8 bytes larger. We might be using different CFLAGs to sparc though. > > I didn't think it made the source significantly clearer to split o

Re: [PATCH 1/4] Add helpers for finding a device node which as a certain property

2008-11-12 Thread Michael Ellerman
On Thu, 2008-11-13 at 17:49 +1100, Michael Ellerman wrote: > On Wed, 2008-11-12 at 22:46 -0800, David Miller wrote: > > From: Michael Ellerman <[EMAIL PROTECTED]> > > Date: Thu, 13 Nov 2008 15:20:35 +1100 (EST) > > > > > + np = from ? from->allnext : allnodes; > > > + for (; np; np = np->allnext)

Re: [PATCH 1/4] Add helpers for finding a device node which as a certain property

2008-11-12 Thread Michael Ellerman
On Wed, 2008-11-12 at 22:46 -0800, David Miller wrote: > From: Michael Ellerman <[EMAIL PROTECTED]> > Date: Thu, 13 Nov 2008 15:20:35 +1100 (EST) > > > + np = from ? from->allnext : allnodes; > > + for (; np; np = np->allnext) { > > + for (pp = np->properties; pp != 0; pp = pp->next)

Re: [PATCH 1/4] Add helpers for finding a device node which as a certain property

2008-11-12 Thread David Miller
From: Michael Ellerman <[EMAIL PROTECTED]> Date: Thu, 13 Nov 2008 15:20:35 +1100 (EST) > + np = from ? from->allnext : allnodes; > + for (; np; np = np->allnext) { > + for (pp = np->properties; pp != 0; pp = pp->next) { > + if (of_prop_cmp(pp->name, prop_nam

[PATCH 1/4] Add helpers for finding a device node which as a certain property

2008-11-12 Thread Michael Ellerman
This commit adds a routine for finding a device node which has a certain property, the contents of the property are not taken into account, merely the presence or absence of the property. Based on that routine, we add a for_each_ macro for iterating over all nodes that have a certain property. Si