On Wed, 2008-11-12 at 22:46 -0800, David Miller wrote:
> From: Michael Ellerman <[EMAIL PROTECTED]>
> Date: Thu, 13 Nov 2008 15:20:35 +1100 (EST)
>
> > + np = from ? from->allnext : allnodes;
> > + for (; np; np = np->allnext) {
> > + for (pp = np->properties; pp != 0; pp = pp->next) {
> > + if (of_prop_cmp(pp->name, prop_name) == 0) {
> > + goto out;
> > + }
> > + }
> > + }
>
> We're starting to duplicate a lot of code in this file.Agreed. > Perhaps split out the locked section of of_find_proeprty() into > a __of_find_property() and use that here and in of_find_property() > as well? Yeah I thought about it, but decided it wasn't worth it. But I'll try it and see how the sizes end up. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
