Re: [PATCH 1/3] Implement arch disable/enable irq hooks.

2007-09-12 Thread Johannes Berg
On Wed, 2007-09-12 at 07:16 +1000, Paul Mackerras wrote: > > +/* Overrides the weak version in kernel/power/main.c */ > > +void arch_suspend_disable_irqs(void) > > +{ > > + if (ppc_md.suspend_disable_irqs) > > + ppc_md.suspend_disable_irqs(); > > + else > > + generic_suspen

Re: [PATCH 1/3] Implement arch disable/enable irq hooks.

2007-09-11 Thread Scott Wood
Paul Mackerras wrote: > It might be better to use hard_irq_disable rather than > local_irq_disable here, since I think we will need that on 64-bit (and > on 32-bit if we ever do lazy irq disabling there). OK. >> +/* Overrides the weak version in kernel/power/main.c */ >> +void arch_suspend_disabl

Re: [PATCH 1/3] Implement arch disable/enable irq hooks.

2007-09-11 Thread Paul Mackerras
Scott Wood writes: > These hooks ensure that a decrementer interrupt is not pending when > suspending; otherwise, problems may occur. For example, with deep sleep > on the 831x, a pending decrementer will cause a system freeze because the > SoC thinks the decrementer interrupt would have woken th

[PATCH 1/3] Implement arch disable/enable irq hooks.

2007-09-05 Thread Scott Wood
These hooks ensure that a decrementer interrupt is not pending when suspending; otherwise, problems may occur. For example, with deep sleep on the 831x, a pending decrementer will cause a system freeze because the SoC thinks the decrementer interrupt would have woken the system, but the core must