Re: [PATCH 1/2] powerpc/math-emu: remove the dead code in math.c

2013-07-09 Thread Benjamin Herrenschmidt
On Wed, 2013-07-10 at 13:25 +1000, Michael Ellerman wrote: > > > Any idea why we have that there? ie. have the config symbols changed > > > over time or was this always dead code? > > > > No idea. I tried to trace this before submitting the patch. But it has > > been there since the begin of the g

Re: [PATCH 1/2] powerpc/math-emu: remove the dead code in math.c

2013-07-09 Thread Kevin Hao
On Wed, Jul 10, 2013 at 01:25:33PM +1000, Michael Ellerman wrote: > On Wed, Jul 10, 2013 at 10:23:07AM +0800, Kevin Hao wrote: > > On Wed, Jul 10, 2013 at 12:01:33PM +1000, Michael Ellerman wrote: > > > On Wed, Jul 10, 2013 at 09:43:42AM +0800, Kevin Hao wrote: > > > > The math.c is only built when

Re: [PATCH 1/2] powerpc/math-emu: remove the dead code in math.c

2013-07-09 Thread Michael Ellerman
On Wed, Jul 10, 2013 at 10:23:07AM +0800, Kevin Hao wrote: > On Wed, Jul 10, 2013 at 12:01:33PM +1000, Michael Ellerman wrote: > > On Wed, Jul 10, 2013 at 09:43:42AM +0800, Kevin Hao wrote: > > > The math.c is only built when CONFIG_MATH_EMULATION is enabled. > > > So we would never get into the ca

Re: [PATCH 1/2] powerpc/math-emu: remove the dead code in math.c

2013-07-09 Thread Kevin Hao
On Wed, Jul 10, 2013 at 12:01:33PM +1000, Michael Ellerman wrote: > On Wed, Jul 10, 2013 at 09:43:42AM +0800, Kevin Hao wrote: > > The math.c is only built when CONFIG_MATH_EMULATION is enabled. > > So we would never get into the case that CONFIG_MATH_EMULATION > > is not defined in this file. > >

Re: [PATCH 1/2] powerpc/math-emu: remove the dead code in math.c

2013-07-09 Thread Michael Ellerman
On Wed, Jul 10, 2013 at 09:43:42AM +0800, Kevin Hao wrote: > The math.c is only built when CONFIG_MATH_EMULATION is enabled. > So we would never get into the case that CONFIG_MATH_EMULATION > is not defined in this file. Any idea why we have that there? ie. have the config symbols changed over tim

[PATCH 1/2] powerpc/math-emu: remove the dead code in math.c

2013-07-09 Thread Kevin Hao
The math.c is only built when CONFIG_MATH_EMULATION is enabled. So we would never get into the case that CONFIG_MATH_EMULATION is not defined in this file. Signed-off-by: Kevin Hao --- arch/powerpc/math-emu/math.c | 42 -- 1 file changed, 42 deletions(-)