On Wed, Jul 10, 2013 at 01:25:33PM +1000, Michael Ellerman wrote: > On Wed, Jul 10, 2013 at 10:23:07AM +0800, Kevin Hao wrote: > > On Wed, Jul 10, 2013 at 12:01:33PM +1000, Michael Ellerman wrote: > > > On Wed, Jul 10, 2013 at 09:43:42AM +0800, Kevin Hao wrote: > > > > The math.c is only built when CONFIG_MATH_EMULATION is enabled. > > > > So we would never get into the case that CONFIG_MATH_EMULATION > > > > is not defined in this file. > > > > > > Any idea why we have that there? ie. have the config symbols changed > > > over time or was this always dead code? > > > > No idea. I tried to trace this before submitting the patch. But it has > > been there since the begin of the git history. So I just assume that it is > > always dead code. :-) > > Yeah looks like it. Even in the git-huge tree I see it in the initial > commit.
Thanks for the confirmation. > > You should say that in the commit message though. Otherwise it's not > clear if you're fixing a recent breakage or not. Indeed. I will wait a little to see if there are any other comments. Then respin a new version to capture such info in the commit log. Thanks, Kevin > > cheers
pgpIqOfJn0Q15.pgp
Description: PGP signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
