Re: [PATCH 1/2] leds: make the default trigger name const

2008-08-28 Thread Trent Piepho
The default_trigger fields of struct gpio_led and thus struct led_classdev are pretty much always assigned from a string literal, which means the string can't be modified. Which is fine, since there is no reason to modify the string and in fact it never is. But they should be marked const to prev

Re: [PATCH 1/2] leds: make the default trigger name const

2008-07-28 Thread Anton Vorontsov
On Sun, Jul 27, 2008 at 06:56:49PM -0700, Trent Piepho wrote: > On Sun, 27 Jul 2008, Stephen Rothwell wrote: > > On Sat, 26 Jul 2008 20:08:57 -0600 Grant Likely <[EMAIL PROTECTED]> wrote: > >> On Fri, Jul 25, 2008 at 02:01:44PM -0700, Trent Piepho wrote: > >>> The default_trigger fields of struct g

Re: [PATCH 1/2] leds: make the default trigger name const

2008-07-27 Thread Trent Piepho
On Sun, 27 Jul 2008, Stephen Rothwell wrote: > On Sat, 26 Jul 2008 20:08:57 -0600 Grant Likely <[EMAIL PROTECTED]> wrote: >> On Fri, Jul 25, 2008 at 02:01:44PM -0700, Trent Piepho wrote: >>> The default_trigger fields of struct gpio_led and thus struct led_classdev >>> are pretty much always assign

Re: [PATCH 1/2] leds: make the default trigger name const

2008-07-27 Thread Stephen Rothwell
Hi Trent, On Sat, 26 Jul 2008 20:08:57 -0600 Grant Likely <[EMAIL PROTECTED]> wrote: > > On Fri, Jul 25, 2008 at 02:01:44PM -0700, Trent Piepho wrote: > > The default_trigger fields of struct gpio_led and thus struct led_classdev > > are pretty much always assigned from a string literal, which mea

Re: [PATCH 1/2] leds: make the default trigger name const

2008-07-26 Thread Grant Likely
On Fri, Jul 25, 2008 at 02:01:44PM -0700, Trent Piepho wrote: > The default_trigger fields of struct gpio_led and thus struct led_classdev > are pretty much always assigned from a string literal, which means the > string can't be modified. Which is fine, since there is no reason to > modify the st

[PATCH 1/2] leds: make the default trigger name const

2008-07-25 Thread Trent Piepho
The default_trigger fields of struct gpio_led and thus struct led_classdev are pretty much always assigned from a string literal, which means the string can't be modified. Which is fine, since there is no reason to modify the string and in fact it never is. But they should be marked const to prev