Re: [PATCH 1/2] [POWERPC] smp_call_function_map should be static

2008-01-01 Thread Benjamin Herrenschmidt
> With the locking changes in 2/2, it will need a new exported function > that does the locking around the call to __*. With that, it'd be easier > to just merge this. > > I.e. __smp_call_function_map() will be the internal (lockless) version, > and you'll end up adding a nonstatic smp_call_funct

Re: [PATCH 1/2] [POWERPC] smp_call_function_map should be static

2008-01-01 Thread Olof Johansson
On Wed, Jan 02, 2008 at 07:28:33AM +1100, Benjamin Herrenschmidt wrote: > > On Thu, 2007-12-27 at 22:08 -0600, Olof Johansson wrote: > > smp_call_function_map should be static, and for consistency prepend it > > with __ like other local helper functions in the same file. > > > > Signed-off-by: Ol

Re: [PATCH 1/2] [POWERPC] smp_call_function_map should be static

2008-01-01 Thread Benjamin Herrenschmidt
On Thu, 2007-12-27 at 22:08 -0600, Olof Johansson wrote: > smp_call_function_map should be static, and for consistency prepend it > with __ like other local helper functions in the same file. > > Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> NAK. I want it exported to other arch code, I'll n

[PATCH 1/2] [POWERPC] smp_call_function_map should be static

2007-12-27 Thread Olof Johansson
smp_call_function_map should be static, and for consistency prepend it with __ like other local helper functions in the same file. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c index 338950a..cefeee8 100644 --- a/arch/powerpc/