Re: [PATCH 1/2] [MTD] Add support for RAM & ROM mappings in the physmap_of MTD driver.

2008-04-25 Thread Laurent Pinchart
On Wednesday 23 April 2008 13:12, Sergei Shtylyov wrote: > David Woodhouse wrote: > > Ok. I'll submit a new patch as soon as we agree on a compatible name. > > >>>Did we? > > >>IIRC, The latest agreement was that we don't need the "compatible" and > >>will match on node name. > > > Ok.

Re: [PATCH 1/2] [MTD] Add support for RAM & ROM mappings in the physmap_of MTD driver.

2008-04-23 Thread Sergei Shtylyov
David Woodhouse wrote: Ok. I'll submit a new patch as soon as we agree on a compatible name. Did we? IIRC, The latest agreement was that we don't need the "compatible" and will match on node name. Ok. Is there a current patch I should be merging? Looks like it was decided to rev

Re: [PATCH 1/2] [MTD] Add support for RAM & ROM mappings in the physmap_of MTD driver.

2008-04-22 Thread David Woodhouse
On Wed, 2008-04-23 at 00:16 +0400, Sergei Shtylyov wrote: > David Woodhouse wrote: > > >>Ok. I'll submit a new patch as soon as we agree on a compatible name. > > > Did we? > > IIRC, The latest agreement was that we don't need the "compatible" and > will match on node name. Ok. Is there a

Re: [PATCH 1/2] [MTD] Add support for RAM & ROM mappings in the physmap_of MTD driver.

2008-04-22 Thread Sergei Shtylyov
David Woodhouse wrote: Ok. I'll submit a new patch as soon as we agree on a compatible name. Did we? IIRC, The latest agreement was that we don't need the "compatible" and will match on node name. WBR, Sergei ___ Linuxppc-dev mailing list Li

Re: [PATCH 1/2] [MTD] Add support for RAM & ROM mappings in the physmap_of MTD driver.

2008-04-22 Thread David Woodhouse
On Thu, 2008-03-27 at 10:26 +0100, Laurent Pinchart wrote: > Ok. I'll submit a new patch as soon as we agree on a compatible name. Did we? -- dwmw2 ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 1/2] [MTD] Add support for RAM & ROM mappings in the physmap_of MTD driver.

2008-03-27 Thread Laurent Pinchart
On Wednesday 26 March 2008 16:34, Segher Boessenkool wrote: > >>> { > >>> +.compatible= "physmap-ram", > >>> +.data= (void *)"map_ram", > >>> +}, > >>> +{ > >>> +.compatible= "physmap-rom", > >>> +.data= (void *)"map_rom", > >>> +

Re: [PATCH 1/2] [MTD] Add support for RAM & ROM mappings in the physmap_of MTD driver.

2008-03-26 Thread David Gibson
On Wed, Mar 26, 2008 at 04:34:58PM +0100, Segher Boessenkool wrote: { +.compatible= "physmap-ram", +.data= (void *)"map_ram", +}, +{ +.compatible= "physmap-rom", +.data= (void *)"map_rom", +

Re: [PATCH 1/2] [MTD] Add support for RAM & ROM mappings in the physmap_of MTD driver.

2008-03-26 Thread Segher Boessenkool
{ +.compatible= "physmap-ram", +.data= (void *)"map_ram", +}, +{ +.compatible= "physmap-rom", +.data= (void *)"map_rom", +}, Why the cast? It's redundant afaics. To be in line with the surrounding code... I see _tha

Re: [PATCH 1/2] [MTD] Add support for RAM & ROM mappings in the physmap_of MTD driver.

2008-03-26 Thread Sergei Shtylyov
Segher Boessenkool wrote: { +.compatible= "physmap-ram", +.data= (void *)"map_ram", +}, +{ +.compatible= "physmap-rom", +.data= (void *)"map_rom", +}, Why the cast? It's redundant afaics. To be in line with the surr

Re: [PATCH 1/2] [MTD] Add support for RAM & ROM mappings in the physmap_of MTD driver.

2008-03-26 Thread Segher Boessenkool
{ + .compatible = "physmap-ram", + .data = (void *)"map_ram", + }, + { + .compatible = "physmap-rom", + .data = (void *)"map_rom", + }, Why the cast? It's redundant afaics. Segher __

[PATCH 1/2] [MTD] Add support for RAM & ROM mappings in the physmap_of MTD driver.

2008-03-26 Thread Laurent Pinchart
Signed-off-by: Laurent Pinchart <[EMAIL PROTECTED]> --- drivers/mtd/maps/physmap_of.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/mtd/maps/physmap_of.c b/drivers/mtd/maps/physmap_of.c index 49acd41..65c30b5 100644 --- a/drivers/mtd/maps/physmap_of.c +++