{
+        .compatible    = "physmap-ram",
+        .data        = (void *)"map_ram",
+    },
+    {
+        .compatible    = "physmap-rom",
+        .data        = (void *)"map_rom",
+    },

Why the cast?  It's redundant afaics.

  To be in line with the surrounding code...

I see _that_, but it's not a great argument IMNSHO.  Could I trick
you into preceding this patch with a cleanup patch for the existing
casts?


Segher

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to