Re: [PATCH 08/26] KVM: PPC: Add PV guest critical sections

2010-06-27 Thread Benjamin Herrenschmidt
On Sun, 2010-06-27 at 14:06 +0200, Alexander Graf wrote: > > Right, I was agreeing with you. I meant there was no inc/dec mem > > insns. > > Ah, I see :). I think that's really the only point where I deem the > x86 isa superior :). Heh, well, that's a typical RISC thing tho. I think ARM and

Re: [PATCH 08/26] KVM: PPC: Add PV guest critical sections

2010-06-27 Thread Alexander Graf
Am 27.06.2010 um 13:53 schrieb Avi Kivity : On 06/27/2010 02:49 PM, Alexander Graf wrote: Am 27.06.2010 um 12:59 schrieb Avi Kivity : On 06/27/2010 01:33 PM, Alexander Graf wrote: Or inc/dec... Uh - huh? How would that help? inc shared->critical # disable interrupts There is no op

Re: [PATCH 08/26] KVM: PPC: Add PV guest critical sections

2010-06-27 Thread Avi Kivity
On 06/27/2010 02:49 PM, Alexander Graf wrote: Am 27.06.2010 um 12:59 schrieb Avi Kivity : On 06/27/2010 01:33 PM, Alexander Graf wrote: Or inc/dec... Uh - huh? How would that help? inc shared->critical # disable interrupts There is no opcode in the ppc isa that acts on momery without

Re: [PATCH 08/26] KVM: PPC: Add PV guest critical sections

2010-06-27 Thread Alexander Graf
Am 27.06.2010 um 12:59 schrieb Avi Kivity : On 06/27/2010 01:33 PM, Alexander Graf wrote: Or inc/dec... Uh - huh? How would that help? inc shared->critical # disable interrupts There is no opcode in the ppc isa that acts on momery without involving a register. An inc would be: ld

Re: [PATCH 08/26] KVM: PPC: Add PV guest critical sections

2010-06-27 Thread Avi Kivity
On 06/27/2010 01:33 PM, Alexander Graf wrote: Or inc/dec... Uh - huh? How would that help? inc shared->critical # disable interrupts -- error compiling committee.c: too many arguments to function ___ Linuxppc-dev mailing list Linuxppc-dev@lists

Re: [PATCH 08/26] KVM: PPC: Add PV guest critical sections

2010-06-27 Thread Alexander Graf
Am 27.06.2010 um 12:03 schrieb Avi Kivity : On 06/26/2010 02:24 AM, Alexander Graf wrote: When running in hooked code we need a way to disable interrupts without clobbering any interrupts or exiting out to the hypervisor. To achieve this, we have an additional critical field in the shared

Re: [PATCH 08/26] KVM: PPC: Add PV guest critical sections

2010-06-27 Thread Alexander Graf
Am 27.06.2010 um 11:52 schrieb Avi Kivity : On 06/27/2010 12:40 PM, Alexander Graf wrote: Am 27.06.2010 um 10:21 schrieb Avi Kivity : On 06/26/2010 02:24 AM, Alexander Graf wrote: When running in hooked code we need a way to disable interrupts without clobbering any interrupts or exiting

Re: [PATCH 08/26] KVM: PPC: Add PV guest critical sections

2010-06-27 Thread Avi Kivity
On 06/26/2010 02:24 AM, Alexander Graf wrote: When running in hooked code we need a way to disable interrupts without clobbering any interrupts or exiting out to the hypervisor. To achieve this, we have an additional critical field in the shared page. If that field is equal to the r1 register of

Re: [PATCH 08/26] KVM: PPC: Add PV guest critical sections

2010-06-27 Thread Avi Kivity
On 06/27/2010 12:40 PM, Alexander Graf wrote: Am 27.06.2010 um 10:21 schrieb Avi Kivity : On 06/26/2010 02:24 AM, Alexander Graf wrote: When running in hooked code we need a way to disable interrupts without clobbering any interrupts or exiting out to the hypervisor. To achieve this, we have

Re: [PATCH 08/26] KVM: PPC: Add PV guest critical sections

2010-06-27 Thread Alexander Graf
Am 27.06.2010 um 10:21 schrieb Avi Kivity : On 06/26/2010 02:24 AM, Alexander Graf wrote: When running in hooked code we need a way to disable interrupts without clobbering any interrupts or exiting out to the hypervisor. To achieve this, we have an additional critical field in the shared

Re: [PATCH 08/26] KVM: PPC: Add PV guest critical sections

2010-06-27 Thread Avi Kivity
On 06/26/2010 02:24 AM, Alexander Graf wrote: When running in hooked code we need a way to disable interrupts without clobbering any interrupts or exiting out to the hypervisor. To achieve this, we have an additional critical field in the shared page. If that field is equal to the r1 register of

[PATCH 08/26] KVM: PPC: Add PV guest critical sections

2010-06-25 Thread Alexander Graf
When running in hooked code we need a way to disable interrupts without clobbering any interrupts or exiting out to the hypervisor. To achieve this, we have an additional critical field in the shared page. If that field is equal to the r1 register of the guest, it tells the hypervisor that we're i