Re: [PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support

2024-07-02 Thread Jarkko Sakkinen
On Wed Jul 3, 2024 at 3:48 AM EEST, Jarkko Sakkinen wrote: > On Wed Jul 3, 2024 at 3:34 AM EEST, Jarkko Sakkinen wrote: > > https://lore.kernel.org/linux-integrity/20240703003033.19057-1-jar...@kernel.org/T/#u > > > > There's also bunch of other drivers than tpm_ibmvtpm so better > > to limit it to

Re: [PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support

2024-07-02 Thread Jarkko Sakkinen
On Wed Jul 3, 2024 at 3:34 AM EEST, Jarkko Sakkinen wrote: > https://lore.kernel.org/linux-integrity/20240703003033.19057-1-jar...@kernel.org/T/#u > > There's also bunch of other drivers than tpm_ibmvtpm so better > to limit it to known good drivers. > > I can take at the actual issue in August and

Re: [PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support

2024-07-02 Thread Jarkko Sakkinen
On Wed Jul 3, 2024 at 2:57 AM EEST, Jarkko Sakkinen wrote: > On Wed, 2024-07-03 at 02:48 +0300, Jarkko Sakkinen wrote: > > On Mon, 2024-07-01 at 15:14 -0400, Stefan Berger wrote: > > > Applying it is probably the better path forward than restricting HMAC to > > > x86_64 now and enabling it on a pe

Re: [PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support

2024-07-02 Thread Jarkko Sakkinen
On Wed, 2024-07-03 at 02:48 +0300, Jarkko Sakkinen wrote: > On Mon, 2024-07-01 at 15:14 -0400, Stefan Berger wrote: > > Applying it is probably the better path forward than restricting HMAC to > > x86_64 now and enabling it on a per-architecture basis afterwards ... > > Why is this here and not i

Re: [PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support

2024-07-02 Thread Jarkko Sakkinen
On Mon, 2024-07-01 at 15:14 -0400, Stefan Berger wrote: > Applying it is probably the better path forward than restricting HMAC to > x86_64 now and enabling it on a per-architecture basis afterwards ... Why is this here and not in the associated patch? Any, what argue against is already done for

Re: [PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support

2024-07-01 Thread Michael Ellerman
James Bottomley writes: > On Fri, 2024-06-28 at 10:54 +1000, Michael Ellerman wrote: >> Stefan Berger writes: >> > Fix the following type of error message caused by a missing call to >> > tpm2_sessions_init() in the IBM vTPM driver: >> > >> > [    2.987131] tpm tpm0: tpm2_load_context: failed wi

Re: [PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support

2024-07-01 Thread Jarkko Sakkinen
On Mon Jul 1, 2024 at 6:29 PM UTC, Stefan Berger wrote: > > > On 7/1/24 11:22, Jarkko Sakkinen wrote: > > On Fri, 2024-06-28 at 17:00 +0200, Linux regression tracking (Thorsten > > Leemhuis) wrote: > >> [CCing the regression list] > >> > >> On 20.06.24 00:34, Stefan Berger wrote: > >>> Jarkko, > >

Re: [PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support

2024-07-01 Thread Stefan Berger
On 7/1/24 15:01, Jarkko Sakkinen wrote: On Mon Jul 1, 2024 at 6:29 PM UTC, Stefan Berger wrote: On 7/1/24 11:22, Jarkko Sakkinen wrote: On Fri, 2024-06-28 at 17:00 +0200, Linux regression tracking (Thorsten Leemhuis) wrote: [CCing the regression list] On 20.06.24 00:34, Stefan Berger wr

Re: [PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support

2024-07-01 Thread Stefan Berger
On 7/1/24 11:22, Jarkko Sakkinen wrote: On Fri, 2024-06-28 at 17:00 +0200, Linux regression tracking (Thorsten Leemhuis) wrote: [CCing the regression list] On 20.06.24 00:34, Stefan Berger wrote: Jarkko,   are you ok with this patch? Hmmm, hope I did not miss anythng, but looks like not

Re: [PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support

2024-07-01 Thread Jarkko Sakkinen
On Fri, 2024-06-28 at 17:00 +0200, Linux regression tracking (Thorsten Leemhuis) wrote: > [CCing the regression list] > > On 20.06.24 00:34, Stefan Berger wrote: > > Jarkko, > >   are you ok with this patch? > > Hmmm, hope I did not miss anythng, but looks like nothing happened for > about 10 da

Re: [PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support

2024-07-01 Thread Jarkko Sakkinen
On Wed, 2024-06-19 at 18:34 -0400, Stefan Berger wrote: > Jarkko, >    are you ok with this patch? Nope :-) It masks a bug, does not fix it. BR, Jarkko

Re: [PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support

2024-07-01 Thread Jarkko Sakkinen
On Mon, 2024-06-17 at 15:34 -0400, Stefan Berger wrote: > Fix the following type of error message caused by a missing call to > tpm2_sessions_init() in the IBM vTPM driver: > > [    2.987131] tpm tpm0: tpm2_load_context: failed with a TPM error 0x01C4 > [    2.987140] ima: Error Communicating to T

Re: [PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support

2024-06-28 Thread Stefan Berger
On 6/28/24 12:39, James Bottomley wrote: On Fri, 2024-06-28 at 10:54 +1000, Michael Ellerman wrote: Stefan Berger writes: Fix the following type of error message caused by a missing call to tpm2_sessions_init() in the IBM vTPM driver: [    2.987131] tpm tpm0: tpm2_load_context: failed with

Re: [PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support

2024-06-28 Thread James Bottomley
On Fri, 2024-06-28 at 10:54 +1000, Michael Ellerman wrote: > Stefan Berger writes: > > Fix the following type of error message caused by a missing call to > > tpm2_sessions_init() in the IBM vTPM driver: > > > > [    2.987131] tpm tpm0: tpm2_load_context: failed with a TPM error > > 0x01C4 > > [ 

Re: [PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support

2024-06-28 Thread Linux regression tracking (Thorsten Leemhuis)
[CCing the regression list] On 20.06.24 00:34, Stefan Berger wrote: > Jarkko, >   are you ok with this patch? Hmmm, hope I did not miss anythng, but looks like nothing happened for about 10 days here. Hence: Jarkko, looks like some feedback from your side really would help to find a path to get

Re: [PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support

2024-06-27 Thread Michael Ellerman
Stefan Berger writes: > Fix the following type of error message caused by a missing call to > tpm2_sessions_init() in the IBM vTPM driver: > > [2.987131] tpm tpm0: tpm2_load_context: failed with a TPM error 0x01C4 > [2.987140] ima: Error Communicating to TPM chip, result: -14 > > Fixes: d2

Re: [PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support

2024-06-19 Thread Stefan Berger
Jarkko, are you ok with this patch? Stefan On 6/17/24 15:34, Stefan Berger wrote: Fix the following type of error message caused by a missing call to tpm2_sessions_init() in the IBM vTPM driver: [2.987131] tpm tpm0: tpm2_load_context: failed with a TPM error 0x01C4 [2.987140] ima:

Re: [PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support

2024-06-17 Thread Stefan Berger
On 6/17/24 16:05, James Bottomley wrote: On Mon, 2024-06-17 at 15:56 -0400, Stefan Berger wrote: On 6/17/24 15:42, James Bottomley wrote: On Mon, 2024-06-17 at 15:34 -0400, Stefan Berger wrote: Fix the following type of error message caused by a missing call to tpm2_sessions_init() in the

Re: [PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support

2024-06-17 Thread James Bottomley
On Mon, 2024-06-17 at 15:56 -0400, Stefan Berger wrote: > > > On 6/17/24 15:42, James Bottomley wrote: > > On Mon, 2024-06-17 at 15:34 -0400, Stefan Berger wrote: > > > Fix the following type of error message caused by a missing call > > > to > > > tpm2_sessions_init() in the IBM vTPM driver: > >

Re: [PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support

2024-06-17 Thread Stefan Berger
On 6/17/24 15:42, James Bottomley wrote: On Mon, 2024-06-17 at 15:34 -0400, Stefan Berger wrote: Fix the following type of error message caused by a missing call to tpm2_sessions_init() in the IBM vTPM driver: [    2.987131] tpm tpm0: tpm2_load_context: failed with a TPM error 0x01C4 [    2.

Re: [PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support

2024-06-17 Thread James Bottomley
On Mon, 2024-06-17 at 15:34 -0400, Stefan Berger wrote: > Fix the following type of error message caused by a missing call to > tpm2_sessions_init() in the IBM vTPM driver: > > [    2.987131] tpm tpm0: tpm2_load_context: failed with a TPM error > 0x01C4 > [    2.987140] ima: Error Communicating to

[PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support

2024-06-17 Thread Stefan Berger
Fix the following type of error message caused by a missing call to tpm2_sessions_init() in the IBM vTPM driver: [2.987131] tpm tpm0: tpm2_load_context: failed with a TPM error 0x01C4 [2.987140] ima: Error Communicating to TPM chip, result: -14 Fixes: d2add27cf2b8 ("tpm: Add NULL primary