Re: [PATCH] powerpc: reduce multi-hit of pcibios_setup_device() in hotplug

2014-06-11 Thread Wei Yang
On Wed, Jun 11, 2014 at 05:29:44PM +1000, Benjamin Herrenschmidt wrote: >On Wed, 2014-06-11 at 15:12 +0800, Wei Yang wrote: > >> Sorry for the long delay. It took me some time to investigate and test the >> code. >> Currently, the hotplug by qemu monitor command line has been verified. Two >> pci

Re: [PATCH] powerpc: reduce multi-hit of pcibios_setup_device() in hotplug

2014-06-11 Thread Benjamin Herrenschmidt
On Wed, 2014-06-11 at 15:12 +0800, Wei Yang wrote: > Sorry for the long delay. It took me some time to investigate and test the > code. > Currently, the hotplug by qemu monitor command line has been verified. Two pci > device on the same bus have been hotpluged one by one successfully. > > Anoth

Re: [PATCH] powerpc: reduce multi-hit of pcibios_setup_device() in hotplug

2014-06-11 Thread Wei Yang
On Mon, May 12, 2014 at 12:59:19PM +1000, Benjamin Herrenschmidt wrote: >On Thu, 2014-05-08 at 14:30 +0800, Wei Yang wrote: >> During the EEH hotplug event, pcibios_setup_device() will be invoked two >> times. And the last time will trigger a warning of re-attachment of iommu >> group. >> >> The t

Re: [PATCH] powerpc: reduce multi-hit of pcibios_setup_device() in hotplug

2014-05-11 Thread Benjamin Herrenschmidt
On Thu, 2014-05-08 at 14:30 +0800, Wei Yang wrote: > During the EEH hotplug event, pcibios_setup_device() will be invoked two > times. And the last time will trigger a warning of re-attachment of iommu > group. > > The two times are: > > pci_device_add > ... > pcibios_add_devi

[PATCH] powerpc: reduce multi-hit of pcibios_setup_device() in hotplug

2014-05-07 Thread Wei Yang
During the EEH hotplug event, pcibios_setup_device() will be invoked two times. And the last time will trigger a warning of re-attachment of iommu group. The two times are: pci_device_add ... pcibios_add_device pcibios_setup_device <- 1st time pcibios_add_pci_dev