Re: [PATCH] powerpc: mm: radix_tlb: rearrange the if-else block

2021-11-26 Thread Christophe Leroy
Le 26/11/2021 à 16:46, Nathan Chancellor a écrit : On Fri, Nov 26, 2021 at 02:59:29PM +0100, Arnd Bergmann wrote: On Fri, Nov 26, 2021 at 2:43 PM Christophe Leroy wrote: Le 25/11/2021 à 16:44, Anders Roxell a écrit : Can't you fix CLANG instead :) ? Or just add an else to the IS_ENABLED(CO

Re: [PATCH] powerpc: mm: radix_tlb: rearrange the if-else block

2021-11-26 Thread Nathan Chancellor
On Fri, Nov 26, 2021 at 02:59:29PM +0100, Arnd Bergmann wrote: > On Fri, Nov 26, 2021 at 2:43 PM Christophe Leroy > wrote: > > Le 25/11/2021 à 16:44, Anders Roxell a écrit : > > Can't you fix CLANG instead :) ? > > > > Or just add an else to the IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) that > > set

Re: [PATCH] powerpc: mm: radix_tlb: rearrange the if-else block

2021-11-26 Thread Arnd Bergmann
On Fri, Nov 26, 2021 at 2:43 PM Christophe Leroy wrote: > Le 25/11/2021 à 16:44, Anders Roxell a écrit : > Can't you fix CLANG instead :) ? > > Or just add an else to the IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) that > sets hstart and hend to 0 ? That doesn't sound any less risky than duplicating

Re: [PATCH] powerpc: mm: radix_tlb: rearrange the if-else block

2021-11-26 Thread Christophe Leroy
Le 25/11/2021 à 16:44, Anders Roxell a écrit : Clang warns: arch/powerpc/mm/book3s64/radix_tlb.c:1191:23: error: variable 'hstart' is uninitialized when used here [-Werror,-Wuninitialized] __tlbiel_va_range(hstart, hend, pid,

[PATCH] powerpc: mm: radix_tlb: rearrange the if-else block

2021-11-25 Thread Anders Roxell
Clang warns: arch/powerpc/mm/book3s64/radix_tlb.c:1191:23: error: variable 'hstart' is uninitialized when used here [-Werror,-Wuninitialized] __tlbiel_va_range(hstart, hend, pid, ^~ arch/powerpc/mm/book3s64/radi