Re: [PATCH] powerpc: add Book E support to 64-bit hibernation

2013-04-08 Thread Scott Wood
gsheng-B40534 > > > Cc: Wood Scott-B07421; Johannes Berg; linuxppc-dev@lists.ozlabs.org > > > Subject: Re: [PATCH] powerpc: add Book E support to 64-bit > > hibernation > > > > > > On 04/02/2013 12:28:40 AM, Wang Dongsheng-B40534 wrote: > > > &

RE: [PATCH] powerpc: add Book E support to 64-bit hibernation

2013-04-06 Thread Wang Dongsheng-B40534
> -Original Message- > From: Wood Scott-B07421 > Sent: Thursday, April 04, 2013 4:16 AM > To: Wang Dongsheng-B40534 > Cc: Wood Scott-B07421; Johannes Berg; linuxppc-dev@lists.ozlabs.org > Subject: Re: [PATCH] powerpc: add Book E support to 64-bit hibernation > >

Re: [PATCH] powerpc: add Book E support to 64-bit hibernation

2013-04-03 Thread Scott Wood
On 04/03/2013 12:36:41 AM, Wang Dongsheng-B40534 wrote: > -Original Message- > From: Wood Scott-B07421 > Sent: Wednesday, April 03, 2013 8:35 AM > To: Wang Dongsheng-B40534 > Cc: Wood Scott-B07421; Johannes Berg; linuxppc-dev@lists.ozlabs.org > Subject: Re: [PATCH] p

RE: [PATCH] powerpc: add Book E support to 64-bit hibernation

2013-04-02 Thread Wang Dongsheng-B40534
> -Original Message- > From: Wood Scott-B07421 > Sent: Wednesday, April 03, 2013 8:35 AM > To: Wang Dongsheng-B40534 > Cc: Wood Scott-B07421; Johannes Berg; linuxppc-dev@lists.ozlabs.org > Subject: Re: [PATCH] powerpc: add Book E support to 64-bit hibernation > >

Re: [PATCH] powerpc: add Book E support to 64-bit hibernation

2013-04-02 Thread Scott Wood
On 04/02/2013 12:28:40 AM, Wang Dongsheng-B40534 wrote: Hi scott & Johannes, Thanks for reviewing. @scott, About this patch, could you please help ack this patch? Please investigate the issue of whether we are loading kernel module code in this step, and whether cache flushing is needed as

RE: [PATCH] powerpc: add Book E support to 64-bit hibernation

2013-04-01 Thread Wang Dongsheng-B40534
s.org > Subject: Re: [PATCH] powerpc: add Book E support to 64-bit hibernation > > On 03/22/2013 05:58:37 AM, Johannes Berg wrote: > > On Tue, 2013-03-19 at 17:16 -0500, Scott Wood wrote: > > > > > > > I wonder about kernel modules, though flushing 32 MiB wouldn&

Re: [PATCH] powerpc: add Book E support to 64-bit hibernation

2013-03-22 Thread Scott Wood
On 03/22/2013 05:58:37 AM, Johannes Berg wrote: On Tue, 2013-03-19 at 17:16 -0500, Scott Wood wrote: > > > I wonder about kernel modules, though flushing 32 MiB wouldn't be > > > adequate there. > > > > Good question, but would they be running? You have to have everything > > built in that

Re: [PATCH] powerpc: add Book E support to 64-bit hibernation

2013-03-22 Thread Johannes Berg
On Tue, 2013-03-19 at 17:16 -0500, Scott Wood wrote: > > > I wonder about kernel modules, though flushing 32 MiB wouldn't be > > > adequate there. > > > > Good question, but would they be running? You have to have everything > > built in that you need to load the image? Or maybe not, with the > >

Re: [PATCH] powerpc: add Book E support to 64-bit hibernation

2013-03-19 Thread Scott Wood
On 03/19/2013 04:22:07 PM, Johannes Berg wrote: On Tue, 2013-03-19 at 16:10 -0500, Scott Wood wrote: > > I was going to say I have no idea, but looking at it again ... this is > > in the *resume* code, not the suspend code as I'd assumed, and on > > resume > > I guess I felt it was safer to n

Re: [PATCH] powerpc: add Book E support to 64-bit hibernation

2013-03-19 Thread Johannes Berg
On Tue, 2013-03-19 at 16:10 -0500, Scott Wood wrote: > > I was going to say I have no idea, but looking at it again ... this is > > in the *resume* code, not the suspend code as I'd assumed, and on > > resume > > I guess I felt it was safer to not assume it didn't change, since it > > could be a

Re: [PATCH] powerpc: add Book E support to 64-bit hibernation

2013-03-19 Thread Scott Wood
On 03/19/2013 03:55:34 PM, Johannes Berg wrote: On Mon, 2013-03-18 at 17:12 -0500, Scott Wood wrote: > Could you elaborate on why book3s flushes the way it does? What's > special about the first 32 MiB? If it's to cover kernel code, why > would that be changing from what's already there? I wa

Re: [PATCH] powerpc: add Book E support to 64-bit hibernation

2013-03-19 Thread Johannes Berg
On Mon, 2013-03-18 at 17:12 -0500, Scott Wood wrote: > Could you elaborate on why book3s flushes the way it does? What's > special about the first 32 MiB? If it's to cover kernel code, why > would that be changing from what's already there? I was going to say I have no idea, but looking at

Re: [PATCH] powerpc: add Book E support to 64-bit hibernation

2013-03-18 Thread Scott Wood
On 03/15/2013 10:22:06 AM, Johannes Berg wrote: On Thu, 2013-03-14 at 11:52 -0500, Scott Wood wrote: > > > +#ifdef CONFIG_PPC_BOOK3S_64 > > > /* can't use RESTORE_SPECIAL(MSR) */ > > > ld r0, SL_MSR(r11) > > > mtmsrd r0, 0 > > > > Unfortunately, I forgot the reaso

Re: [PATCH] powerpc: add Book E support to 64-bit hibernation

2013-03-16 Thread Johannes Berg
On Thu, 2013-03-14 at 11:52 -0500, Scott Wood wrote: > > > +#ifdef CONFIG_PPC_BOOK3S_64 > > > /* can't use RESTORE_SPECIAL(MSR) */ > > > ld r0, SL_MSR(r11) > > > mtmsrd r0, 0 > > > > Unfortunately, I forgot the reason for this comment, and didn't put a > > better one (almost 6 years ag

Re: [PATCH] powerpc: add Book E support to 64-bit hibernation

2013-03-14 Thread Scott Wood
On 03/14/2013 03:37:53 AM, Johannes Berg wrote: On Thu, 2013-03-14 at 11:36 +0800, Wang Dongsheng wrote: > +#ifdef CONFIG_PPC_BOOK3S_64 >/* can't use RESTORE_SPECIAL(MSR) */ >ld r0, SL_MSR(r11) >mtmsrd r0, 0 Unfortunately, I forgot the reason for this comment, and didn't put a

Re: [PATCH] powerpc: add Book E support to 64-bit hibernation

2013-03-14 Thread Johannes Berg
On Thu, 2013-03-14 at 11:36 +0800, Wang Dongsheng wrote: > +#ifdef CONFIG_PPC_BOOK3S_64 > /* can't use RESTORE_SPECIAL(MSR) */ > ld r0, SL_MSR(r11) > mtmsrd r0, 0 Unfortunately, I forgot the reason for this comment, and didn't put a better one (almost 6 years ago!!) > +

[PATCH] powerpc: add Book E support to 64-bit hibernation

2013-03-13 Thread Wang Dongsheng
Update the 64-bit hibernation code to support Book E CPUs. Some registers and instructions are not defined for Book3e (SDR reg, tlbia instruction). SDR: Storage Description Register. Book3S and Book3E have different address translation mode, we do not need HTABORG & HTABSIZE to translate virtual a

RE: [RFC][PATCH] powerpc: add Book E support to 64-bit hibernation

2013-02-22 Thread Wang Dongsheng-B40534
gt; Subject: Re: [RFC][PATCH] powerpc: add Book E support to 64-bit > hibernation > > Hi, > > > > Subject: [RFC][PATCH] powerpc: add Book E support to 64-bit > > > hibernation > > > Any thoughts about this patch? > > Heh, honestly, no. I know nothing a

Re: [RFC][PATCH] powerpc: add Book E support to 64-bit hibernation

2013-02-22 Thread Johannes Berg
Hi, > > Subject: [RFC][PATCH] powerpc: add Book E support to 64-bit hibernation > Any thoughts about this patch? Heh, honestly, no. I know nothing about Book E, and it's too long ago that I wrote (some of) the 64-bit hibernation c

RE: [RFC][PATCH] powerpc: add Book E support to 64-bit hibernation

2013-02-21 Thread Wang Dongsheng-B40534
B40534 > Subject: [RFC][PATCH] powerpc: add Book E support to 64-bit hibernation > > Update the 64-bit hibernation code to support Book E CPUs. > Some registers and instructions are not defined for Book3e > (SDR reg, tlbia instruction). > SDR: Storage Description Register. Bo

[RFC][PATCH] powerpc: add Book E support to 64-bit hibernation

2013-02-06 Thread Wang Dongsheng
Update the 64-bit hibernation code to support Book E CPUs. Some registers and instructions are not defined for Book3e (SDR reg, tlbia instruction). SDR: Storage Description Register. Book3S and Book3E have different address translation mode, we do not need HTABORG & HTABSIZE to translate virtual ad