Hi scott & Johannes, Thanks for reviewing.
@scott, About this patch, could you please help ack this patch? > -----Original Message----- > From: Wood Scott-B07421 > Sent: Saturday, March 23, 2013 6:15 AM > To: Johannes Berg > Cc: Wang Dongsheng-B40534; [email protected] > Subject: Re: [PATCH] powerpc: add Book E support to 64-bit hibernation > > On 03/22/2013 05:58:37 AM, Johannes Berg wrote: > > On Tue, 2013-03-19 at 17:16 -0500, Scott Wood wrote: > > > > > > > I wonder about kernel modules, though flushing 32 MiB wouldn't > > be > > > > > adequate there. > > > > > > > > Good question, but would they be running? You have to have > > everything > > > > built in that you need to load the image? Or maybe not, with the > > > > userspace image restoration that became possible at some point... > > > > > > Is that all that's being restored in this step, or would we be > > loading > > > all modules that were loaded before suspend (as they're normally not > > > swappable)? I'm not too familiar with what gets saved where. > > > > Yes, they would be restored since full memory is restored, but the > > kernel doing the restore hasn't typically had a chance to load > > modules. > > Although with uswsusp there probably are ways it can already have. > > If we're loading executable code that wasn't there before[1], we need to > flush -- but there's no reason why modules would only be in the lower 32 > MiB. > > -Scott > > [1] within the resume process, not before suspend _______________________________________________ Linuxppc-dev mailing list [email protected] https://lists.ozlabs.org/listinfo/linuxppc-dev
