Re: [PATCH] powerpc: Fix bogus cache flushing on all 40x and BookE processors v2

2008-12-04 Thread Benjamin Herrenschmidt
On Thu, 2008-12-04 at 07:33 -0500, Josh Boyer wrote: > On Thu, 04 Dec 2008 17:12:59 +1100 > Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > > We were missing the CPU_FTR_NOEXECUTE bit in our cputable for all > > these processors. The result is that update_mmu_cache() would flush > > the cach

Re: [PATCH] powerpc: Fix bogus cache flushing on all 40x and BookE processors v2

2008-12-04 Thread Josh Boyer
On Thu, 04 Dec 2008 17:12:59 +1100 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > We were missing the CPU_FTR_NOEXECUTE bit in our cputable for all > these processors. The result is that update_mmu_cache() would flush > the cache for all pages mapped to userspace which is totally > unnecessar

[PATCH] powerpc: Fix bogus cache flushing on all 40x and BookE processors v2

2008-12-03 Thread Benjamin Herrenschmidt
We were missing the CPU_FTR_NOEXECUTE bit in our cputable for all these processors. The result is that update_mmu_cache() would flush the cache for all pages mapped to userspace which is totally unnecessary on those processors since we already handle flushing on execute in the page fault path. Thi

Re: [PATCH] powerpc: Fix bogus cache flushing on all 40x and BookE processors

2008-12-03 Thread Benjamin Herrenschmidt
On Wed, 2008-12-03 at 15:09 -0800, Trent Piepho wrote: > #ifdef __powerpc64__ > #define LONG_ASM_CONST(x) ASM_CONST(x) > #else > #define LONG_ASM_CONST(x) 0 > #endif > > #define CPU_FTR_NOEXECUTE LONG_ASM_CONST(0x0008) > > Am I not looking at

Re: [PATCH] powerpc: Fix bogus cache flushing on all 40x and BookE processors

2008-12-03 Thread Trent Piepho
On Tue, 2 Dec 2008, Benjamin Herrenschmidt wrote: > On Tue, 2008-12-02 at 01:36 -0600, Kumar Gala wrote: > >>> #define CPU_FTRS_E200 (CPU_FTR_USE_TB | CPU_FTR_SPE_COMP | \ >>> CPU_FTR_NODSISRALIGN | CPU_FTR_COHERENT_ICACHE | \ >>> - CPU_FTR_UNIFIED_ID_CACHE) >>> + CPU_FTR_

Re: [PATCH] powerpc: Fix bogus cache flushing on all 40x and BookE processors

2008-12-02 Thread Steven A. Falco
Kumar Gala wrote: > > > On Dec 1, 2008, at 12:01 AM, Benjamin Herrenschmidt wrote: > >> We were missing the CPU_FTR_NOEXECUTE bit in our cputable for all >> these processors. The result is that update_mmu_cache() would flush >> the cache for all pages mapped to userspace which is totally >> unne

Re: [PATCH] powerpc: Fix bogus cache flushing on all 40x and BookE processors

2008-12-02 Thread Benjamin Herrenschmidt
On Tue, 2008-12-02 at 01:36 -0600, Kumar Gala wrote: > > #define CPU_FTRS_E200 (CPU_FTR_USE_TB | CPU_FTR_SPE_COMP | \ > > CPU_FTR_NODSISRALIGN | CPU_FTR_COHERENT_ICACHE | \ > > - CPU_FTR_UNIFIED_ID_CACHE) > > + CPU_FTR_UNIFIED_ID_CACHE | CPU_FTR_NOEXECUTE) > > #define CPU

Re: [PATCH] powerpc: Fix bogus cache flushing on all 40x and BookE processors

2008-12-01 Thread Kumar Gala
On Dec 1, 2008, at 12:01 AM, Benjamin Herrenschmidt wrote: We were missing the CPU_FTR_NOEXECUTE bit in our cputable for all these processors. The result is that update_mmu_cache() would flush the cache for all pages mapped to userspace which is totally unnecessary on those processors since we

[PATCH] powerpc: Fix bogus cache flushing on all 40x and BookE processors

2008-11-30 Thread Benjamin Herrenschmidt
We were missing the CPU_FTR_NOEXECUTE bit in our cputable for all these processors. The result is that update_mmu_cache() would flush the cache for all pages mapped to userspace which is totally unnecessary on those processors since we already handle flushing on execute in the page fault path. Thi