On Mon, Feb 22, 2010 at 9:05 AM, Matthias Fuchs
wrote:
> Hi Grant,
>
> thanks for comments. I will post an updated version soon.
>
>
> On Tuesday 16 February 2010 20:19, Grant Likely wrote:
>> > + return 0;
>> > +}
>> > +arch_initcall(mpc512x_add_gpiochips);
>>
>> Don't do this. Either make
Hi Grant,
thanks for comments. I will post an updated version soon.
On Tuesday 16 February 2010 20:19, Grant Likely wrote:
> > + return 0;
> > +}
> > +arch_initcall(mpc512x_add_gpiochips);
>
> Don't do this. Either make this a proper of_platform device driver,
> or call mpc512x_add_gpioc
Hi Matthias. Thanks for the patch. Some comments below...
On Thu, Jan 28, 2010 at 6:48 AM, Matthias Fuchs
wrote:
> Signed-off-by: Matthias Fuchs
Could use a commit log. It is useful to give some details about what
this driver has been developed/tested on.
> ---
> arch/powerpc/include/asm/m
Signed-off-by: Matthias Fuchs
---
arch/powerpc/include/asm/mpc512x_gpio.h | 30 +
arch/powerpc/platforms/Kconfig |9 ++
arch/powerpc/sysdev/Makefile|1 +
arch/powerpc/sysdev/mpc512x_gpio.c | 179 +++
4 files changed, 219 inserti
