On Mon, Feb 22, 2010 at 9:05 AM, Matthias Fuchs <matthias.fu...@esd-electronics.com> wrote: > Hi Grant, > > thanks for comments. I will post an updated version soon. > > > On Tuesday 16 February 2010 20:19, Grant Likely wrote: >> > + return 0; >> > +} >> > +arch_initcall(mpc512x_add_gpiochips); >> >> Don't do this. Either make this a proper of_platform device driver, >> or call mpc512x_add_gpiochips() explicitly from the arch platform >> setup code. Otherwise, if the kernel is built for multiplatform, this >> function will get executed regardless of the platform. > In this case I prefer moving the call to the platform code. > I tested the driver on one of our 5123 boards. Shall I add it > to mpc5121_ads.c:mpc5121_ads_setup_arch() also? So it's at least called > on the reference board? I not sure if there are some LEDs or buttons > that could use it.
Yes, make sure all 5121 platforms call it. Thanks, g. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
