Re: [PATCH] powerpc/83xx: Fix few build errors with CONFIG_QUICC_ENGINE=n

2008-12-30 Thread Kumar Gala
On Dec 5, 2008, at 10:55 AM, Anton Vorontsov wrote: Some 83xx boards were not ready for the optional QUICC Engine support. This patch fixes following build errors: arch/powerpc/platforms/built-in.o: In function `flush_disable_caches': (.text+0xb308): undefined reference to `par_io_data_set' a

Re: [PATCH] powerpc/83xx: Fix few build errors with CONFIG_QUICC_ENGINE=n

2008-12-22 Thread Anton Vorontsov
On Fri, Dec 05, 2008 at 07:55:04PM +0300, Anton Vorontsov wrote: > Some 83xx boards were not ready for the optional QUICC Engine support. > > This patch fixes following build errors: > > arch/powerpc/platforms/built-in.o: In function `flush_disable_caches': > (.text+0xb308): undefined reference t

Re: [PATCH] powerpc/83xx: Fix few build errors with CONFIG_QUICC_ENGINE=n

2008-12-16 Thread Kumar Gala
On Dec 16, 2008, at 1:14 PM, Anton Vorontsov wrote: On Tue, Dec 16, 2008 at 01:00:13PM -0600, Scott Wood wrote: Anton Vorontsov wrote: GCC can still issue the of_find_node_by_name() call. (I wonder if there is any way to tell gcc that particular function doesn't produce any side-effects so

Re: [PATCH] powerpc/83xx: Fix few build errors with CONFIG_QUICC_ENGINE=n

2008-12-16 Thread Anton Vorontsov
On Tue, Dec 16, 2008 at 01:00:13PM -0600, Scott Wood wrote: > Anton Vorontsov wrote: >> GCC can still issue the of_find_node_by_name() call. (I wonder if >> there is any way to tell gcc that particular function doesn't >> produce any side-effects so that gcc can optimize it away too). > > __a

Re: [PATCH] powerpc/83xx: Fix few build errors with CONFIG_QUICC_ENGINE=n

2008-12-16 Thread Scott Wood
Anton Vorontsov wrote: GCC can still issue the of_find_node_by_name() call. (I wonder if there is any way to tell gcc that particular function doesn't produce any side-effects so that gcc can optimize it away too). __attribute__((pure)) -Scott

Re: [PATCH] powerpc/83xx: Fix few build errors with CONFIG_QUICC_ENGINE=n

2008-12-16 Thread Anton Vorontsov
On Tue, Dec 16, 2008 at 12:18:07PM -0600, Kumar Gala wrote: [..] >> This patch implements traditional way of !QE case handling. >> Alternative version is coming (w/o ifdefs in the board files). >> >> p.s. I don't know if it is 2.6.28 material... > > what's the state of this patch vs the alternate v

Re: [PATCH] powerpc/83xx: Fix few build errors with CONFIG_QUICC_ENGINE=n

2008-12-16 Thread Kumar Gala
On Dec 5, 2008, at 10:55 AM, Anton Vorontsov wrote: Some 83xx boards were not ready for the optional QUICC Engine support. This patch fixes following build errors: arch/powerpc/platforms/built-in.o: In function `flush_disable_caches': (.text+0xb308): undefined reference to `par_io_data_set' a

Re: [PATCH] powerpc/83xx: Fix few build errors with CONFIG_QUICC_ENGINE=n

2008-12-05 Thread Timur Tabi
Kumar Gala wrote: > this doesn't seem critical right now so I'd say we wait for .29 I agree. None of the defconfigs or default behavior expose this bug. I don't expect anyone to actually turn off the QE in a real-world situation. -- Timur Tabi Linux kernel developer at Freescale _

Re: [PATCH] powerpc/83xx: Fix few build errors with CONFIG_QUICC_ENGINE=n

2008-12-05 Thread Kumar Gala
On Dec 5, 2008, at 10:55 AM, Anton Vorontsov wrote: This patch implements traditional way of !QE case handling. Alternative version is coming (w/o ifdefs in the board files). p.s. I don't know if it is 2.6.28 material... arch/powerpc/platforms/83xx/mpc832x_rdb.c |3 ++- arch/powerpc/platfo

[PATCH] powerpc/83xx: Fix few build errors with CONFIG_QUICC_ENGINE=n

2008-12-05 Thread Anton Vorontsov
Some 83xx boards were not ready for the optional QUICC Engine support. This patch fixes following build errors: arch/powerpc/platforms/built-in.o: In function `flush_disable_caches': (.text+0xb308): undefined reference to `par_io_data_set' arch/powerpc/platforms/built-in.o: In function `flush_dis