On Tue, Dec 16, 2008 at 12:18:07PM -0600, Kumar Gala wrote:
[..]
>> This patch implements traditional way of !QE case handling.
>> Alternative version is coming (w/o ifdefs in the board files).
>>
>> p.s. I don't know if it is 2.6.28 material...
>
> what's the state of this patch vs the alternate version?
Pros of the alternative version:
- No #ifdefs in .c files.
Cons of the alternative version:
- For this code (assuming QE=n):
if ((np = of_find_node_by_name(NULL, "par_io")) != NULL)
par_io_init(np);
GCC can still issue the of_find_node_by_name() call. (I wonder if
there is any way to tell gcc that particular function doesn't
produce any side-effects so that gcc can optimize it away too).
It's up to you to decide which version you want to merge.
--
Anton Vorontsov
email: cbouatmai...@gmail.com
irc://irc.freenode.net/bd2
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
